[PR #338] [MERGED] Make read_system_conf() function public #1380

New issue

Closed

opened 2026-03-16 02:03:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:03:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/338
Author: @oherrala
Created: 2/8/2018
Status: ✅ Merged
Merged: 2/11/2018
Merged by: @bluejekyll

Base: master ← Head: pub-resolv-conf

📝 Commits (2)

a1e5189 Make read_system_conf() function public
978d8dd Merge branch 'master' into pub-resolv-conf

📊 Changes

3 files changed (+4 additions, -4 deletions)

View changed files

📝 resolver/src/system_conf/mod.rs (+2 -2)
📝 resolver/src/system_conf/unix.rs (+1 -1)
📝 resolver/src/system_conf/windows.rs (+1 -1)

📄 Description

There are cases where it's useful to get configured DNS servers from running system. For example I'm using trust-dns DNS client with host's configured DNS servers from /etc/resolv.conf. Making this function public scratches that itch.

Before merging #335 the function read_resolv_conf() was public, but it has no equivalent on Windows side. read_system_conf() is available on all platforms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/338 **Author:** [@oherrala](https://github.com/oherrala) **Created:** 2/8/2018 **Status:** ✅ Merged **Merged:** 2/11/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `pub-resolv-conf` --- ### 📝 Commits (2) - [`a1e5189`](https://github.com/hickory-dns/hickory-dns/commit/a1e518997da2ef1837ad7f43d68a9b159c10d0bf) Make read_system_conf() function public - [`978d8dd`](https://github.com/hickory-dns/hickory-dns/commit/978d8ddd4ebc7c0edb205f34d809c37b6c378836) Merge branch 'master' into pub-resolv-conf ### 📊 Changes **3 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `resolver/src/system_conf/mod.rs` (+2 -2) 📝 `resolver/src/system_conf/unix.rs` (+1 -1) 📝 `resolver/src/system_conf/windows.rs` (+1 -1) </details> ### 📄 Description There are cases where it's useful to get configured DNS servers from running system. For example I'm using trust-dns DNS client with host's configured DNS servers from `/etc/resolv.conf`. Making this function public scratches that itch. Before merging #335 the function `read_resolv_conf()` was public, but it has no equivalent on Windows side. `read_system_conf()` is available on all platforms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>