[PR #343] [MERGED] Fix localhost lookup #1378

New issue

Closed

opened 2026-03-16 02:03:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:03:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/343
Author: @bluejekyll
Created: 2/10/2018
Status: ✅ Merged
Merged: 2/10/2018
Merged by: @bluejekyll

Base: master ← Head: fix_localhost_lookup

📝 Commits (6)

1fd6450 fix Arc creation for Hosts to actually reference count
e390f23 allow localhost lookups regardless of ndots
4d0ac83 Merge branch 'master' into fix_localhost_lookup
9ab124e adjust localhost lookup test
0153596 fix hosts to isolate ipv6 and ipv4 separately
efd3aa7 fix integration tests with hosts

📊 Changes

7 files changed (+209 additions, -52 deletions)

View changed files

📝 integration-tests/tests/lookup_tests.rs (+2 -1)
📝 proto/src/rr/domain/name.rs (+22 -0)
📝 resolver/src/config.rs (+3 -3)
📝 resolver/src/hosts.rs (+72 -17)
📝 resolver/src/lookup.rs (+5 -3)
📝 resolver/src/lookup_ip.rs (+58 -27)
📝 resolver/src/resolver_future.rs (+47 -1)

📄 Description

fixes #340

I also changed this to no longer panic on no names, and instead return an error. Should have had it this way before.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/343 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 2/10/2018 **Status:** ✅ Merged **Merged:** 2/10/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix_localhost_lookup` --- ### 📝 Commits (6) - [`1fd6450`](https://github.com/hickory-dns/hickory-dns/commit/1fd645031742d8e7a63f8d5506117031739b7004) fix Arc creation for Hosts to actually reference count - [`e390f23`](https://github.com/hickory-dns/hickory-dns/commit/e390f23e3fc16e2f7786e83f2eb441c5a4f0b7ff) allow localhost lookups regardless of ndots - [`4d0ac83`](https://github.com/hickory-dns/hickory-dns/commit/4d0ac835f37075b3495987e8dbd722ec2c47b3bb) Merge branch 'master' into fix_localhost_lookup - [`9ab124e`](https://github.com/hickory-dns/hickory-dns/commit/9ab124e3a9b2f9a75138550cec2efaef4753c736) adjust localhost lookup test - [`0153596`](https://github.com/hickory-dns/hickory-dns/commit/015359674819dfe0cb994f595c8580942398b8e9) fix hosts to isolate ipv6 and ipv4 separately - [`efd3aa7`](https://github.com/hickory-dns/hickory-dns/commit/efd3aa7728ee5d606b271d65d3b71b0942f5a30f) fix integration tests with hosts ### 📊 Changes **7 files changed** (+209 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `integration-tests/tests/lookup_tests.rs` (+2 -1) 📝 `proto/src/rr/domain/name.rs` (+22 -0) 📝 `resolver/src/config.rs` (+3 -3) 📝 `resolver/src/hosts.rs` (+72 -17) 📝 `resolver/src/lookup.rs` (+5 -3) 📝 `resolver/src/lookup_ip.rs` (+58 -27) 📝 `resolver/src/resolver_future.rs` (+47 -1) </details> ### 📄 Description fixes #340 I also changed this to no longer panic on no names, and instead return an error. Should have had it this way before. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>