[PR #333] [MERGED] Add RecordType::ZERO && RData::ZERO fixing SIG(0) #1375

New issue

Closed

opened 2026-03-16 02:02:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:02:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/333
Author: @bluejekyll
Created: 1/26/2018
Status: ✅ Merged
Merged: 1/26/2018
Merged by: @bluejekyll

Base: master ← Head: fix_sig_0

📝 Commits (1)

8f5febe Add RecordType::ZERO && RData::ZERO fixing SIG(0)

📊 Changes

4 files changed (+19 additions, -2 deletions)

View changed files

📝 client/src/rr/dnssec/signer.rs (+2 -2)
📝 client/src/serialize/txt/parse_rdata.rs (+1 -0)
📝 proto/src/rr/record_data.rs (+10 -0)
📝 proto/src/rr/record_type.rs (+6 -0)

📄 Description

After merging #329 it was noticed that SIG(0) compatibility tests started failing. This was due to the SIG(0) signing process relying on the RecordType being set to 0. After changing NULL to it's correct type of 10, this exposed an erroneous usage of NULL for 0. There is now an explicit ZERO type to compliment the NULL type. The ZERO type will always be 0, it will serialize no bytes (or deserialize), i.e. the RData length is 0.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/333 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 1/26/2018 **Status:** ✅ Merged **Merged:** 1/26/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix_sig_0` --- ### 📝 Commits (1) - [`8f5febe`](https://github.com/hickory-dns/hickory-dns/commit/8f5febeb3f20ff10e66a15300d03e704bd2e655e) Add RecordType::ZERO && RData::ZERO fixing SIG(0) ### 📊 Changes **4 files changed** (+19 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `client/src/rr/dnssec/signer.rs` (+2 -2) 📝 `client/src/serialize/txt/parse_rdata.rs` (+1 -0) 📝 `proto/src/rr/record_data.rs` (+10 -0) 📝 `proto/src/rr/record_type.rs` (+6 -0) </details> ### 📄 Description After merging #329 it was noticed that `SIG(0)` compatibility tests started failing. This was due to the `SIG(0)` signing process relying on the `RecordType` being set to `0`. After changing `NULL` to it's correct type of `10`, this exposed an erroneous usage of `NULL` for `0`. There is now an explicit `ZERO` type to compliment the `NULL` type. The `ZERO` type will always be `0`, it will serialize no bytes (or deserialize), i.e. the RData length is `0`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>