[PR #328] [MERGED] NameUsage patterns #1368

New issue

Closed

opened 2026-03-16 02:02:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:02:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/328
Author: @bluejekyll
Created: 1/18/2018
Status: ✅ Merged
Merged: 1/26/2018
Merged by: @bluejekyll

Base: master ← Head: reserved_names

📝 Commits (10+)

4a0af3b NameUsage with trie for all zones and ancestor search
ca745d3 rename to ZoneUsage and cleanup
120a715 add early return for loopback and nxdomain zones
2b4122d add early return test for localhost
be8098c revert the IntoName to consume self
18d0987 Merge branch 'master' into reserved_names
b1a80e0 move non-essential usages out to client
fe7af02 Merge branch 'reserved_names' of github.com:bluejekyll/trust-dns into reserved_names
1ea1db4 Merge branch 'master' into reserved_names
432b062 add .invalid test

📊 Changes

17 files changed (+916 additions, -21 deletions)

View changed files

📝 Cargo.lock (+25 -0)
📝 README.md (+1 -0)
📝 client/Cargo.toml (+2 -0)
📝 client/src/lib.rs (+3 -0)
📝 client/src/rr/mod.rs (+1 -0)
➕ client/src/rr/zone.rs (+331 -0)
📝 copyright.txt (+2 -1)
📝 proto/src/lib.rs (+3 -1)
📝 proto/src/rr/domain/mod.rs (+2 -1)
📝 proto/src/rr/domain/name.rs (+7 -7)
➕ proto/src/rr/domain/usage.rs (+412 -0)
📝 resolver/Cargo.toml (+1 -0)
📝 resolver/src/hosts.rs (+1 -0)
📝 resolver/src/lib.rs (+2 -0)
📝 resolver/src/lookup.rs (+7 -1)
📝 resolver/src/lookup_state.rs (+108 -2)
📝 resolver/src/resolver_future.rs (+8 -8)

📄 Description

fixes: #323
fixes: #324

This creates a static list of all reserved names in DNS.

@briansmith, you may be interested in this. I'm not sure about the NameUsage associated enum type variants yet. It was a rough attempt at capturing the information from https://tools.ietf.org/html/rfc6761

It uses the radix_trie for zone storage and search, which has a nice ancestor search perfect for finding the encapsulating zone for sub-domains.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/328 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 1/18/2018 **Status:** ✅ Merged **Merged:** 1/26/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `reserved_names` --- ### 📝 Commits (10+) - [`4a0af3b`](https://github.com/hickory-dns/hickory-dns/commit/4a0af3b627bc8d220944b5d96163bba22dbee1ae) NameUsage with trie for all zones and ancestor search - [`ca745d3`](https://github.com/hickory-dns/hickory-dns/commit/ca745d35eb6dc46b1b0c6c8df3c9e461823a4c92) rename to ZoneUsage and cleanup - [`120a715`](https://github.com/hickory-dns/hickory-dns/commit/120a7158b0bacc6052d97166fedb0e688fcf6809) add early return for loopback and nxdomain zones - [`2b4122d`](https://github.com/hickory-dns/hickory-dns/commit/2b4122d1a5eb6443df4f0eba072793fb6e1845e8) add early return test for localhost - [`be8098c`](https://github.com/hickory-dns/hickory-dns/commit/be8098c5858263888a22b953a70d187a3a951ae0) revert the IntoName to consume self - [`18d0987`](https://github.com/hickory-dns/hickory-dns/commit/18d098711456cafdfd2b0c602f140da26404d78d) Merge branch 'master' into reserved_names - [`b1a80e0`](https://github.com/hickory-dns/hickory-dns/commit/b1a80e019e50bb655d62571fb11fc6ec3d01e9b8) move non-essential usages out to client - [`fe7af02`](https://github.com/hickory-dns/hickory-dns/commit/fe7af02fc25e93b4fd252cfa3585ef17f0abab97) Merge branch 'reserved_names' of github.com:bluejekyll/trust-dns into reserved_names - [`1ea1db4`](https://github.com/hickory-dns/hickory-dns/commit/1ea1db4a7bb094954721153feb9e0888ac1abdfe) Merge branch 'master' into reserved_names - [`432b062`](https://github.com/hickory-dns/hickory-dns/commit/432b0621b14423351342a9269e31515f4945d49f) add .invalid test ### 📊 Changes **17 files changed** (+916 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+25 -0) 📝 `README.md` (+1 -0) 📝 `client/Cargo.toml` (+2 -0) 📝 `client/src/lib.rs` (+3 -0) 📝 `client/src/rr/mod.rs` (+1 -0) ➕ `client/src/rr/zone.rs` (+331 -0) 📝 `copyright.txt` (+2 -1) 📝 `proto/src/lib.rs` (+3 -1) 📝 `proto/src/rr/domain/mod.rs` (+2 -1) 📝 `proto/src/rr/domain/name.rs` (+7 -7) ➕ `proto/src/rr/domain/usage.rs` (+412 -0) 📝 `resolver/Cargo.toml` (+1 -0) 📝 `resolver/src/hosts.rs` (+1 -0) 📝 `resolver/src/lib.rs` (+2 -0) 📝 `resolver/src/lookup.rs` (+7 -1) 📝 `resolver/src/lookup_state.rs` (+108 -2) 📝 `resolver/src/resolver_future.rs` (+8 -8) </details> ### 📄 Description fixes: #323 fixes: #324 This creates a static list of all reserved names in DNS. @briansmith, you may be interested in this. I'm not sure about the NameUsage associated enum type variants yet. It was a rough attempt at capturing the information from https://tools.ietf.org/html/rfc6761 It uses the `radix_trie` for zone storage and search, which has a nice ancestor search perfect for finding the encapsulating zone for sub-domains. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>