[PR #313] [MERGED] Support `from_system_conf` on windows 32-bit targets #1363

New issue

Closed

opened 2026-03-16 02:02:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:02:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/313
Author: @liranringel
Created: 12/14/2017
Status: ✅ Merged
Merged: 12/17/2017
Merged by: @bluejekyll

Base: master ← Head: system-conf-windows-32bit

📝 Commits (2)

5788514 Support from_system_conf on windows 32-bit targets
d668fea Merge branch 'master' into system-conf-windows-32bit

📊 Changes

5 files changed (+9 additions, -15 deletions)

View changed files

📝 resolver/Cargo.toml (+2 -3)
📝 resolver/src/lib.rs (+1 -1)
📝 resolver/src/resolver.rs (+2 -4)
📝 resolver/src/resolver_future.rs (+2 -4)
📝 resolver/src/system_conf/mod.rs (+2 -3)

📄 Description

The ipconfig crate supports 32-bit, so I removed the restriction of 64-bit.
Also removed the ipconfig feature, as discussed here: https://github.com/bluejekyll/trust-dns/pull/269

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/313 **Author:** [@liranringel](https://github.com/liranringel) **Created:** 12/14/2017 **Status:** ✅ Merged **Merged:** 12/17/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `system-conf-windows-32bit` --- ### 📝 Commits (2) - [`5788514`](https://github.com/hickory-dns/hickory-dns/commit/57885140b2307dccb02ce569f6e52f06b02666bb) Support `from_system_conf` on windows 32-bit targets - [`d668fea`](https://github.com/hickory-dns/hickory-dns/commit/d668fea143771b6674200e5a07bd6e0512553806) Merge branch 'master' into system-conf-windows-32bit ### 📊 Changes **5 files changed** (+9 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `resolver/Cargo.toml` (+2 -3) 📝 `resolver/src/lib.rs` (+1 -1) 📝 `resolver/src/resolver.rs` (+2 -4) 📝 `resolver/src/resolver_future.rs` (+2 -4) 📝 `resolver/src/system_conf/mod.rs` (+2 -3) </details> ### 📄 Description The `ipconfig` crate supports 32-bit, so I removed the restriction of 64-bit. Also removed the `ipconfig` feature, as discussed here: https://github.com/bluejekyll/trust-dns/pull/269 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>