[PR #325] [MERGED] fixup Name and Label to support punycode #1362

New issue

Closed

opened 2026-03-16 02:02:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:02:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/325
Author: @bluejekyll
Created: 1/4/2018
Status: ✅ Merged
Merged: 1/14/2018
Merged by: @bluejekyll

Base: master ← Head: support-punycode

📝 Commits (9)

3129e97 fixup Name and Label to support punycode
95e3557 add strict methods on Label for conversions
a349a18 add name::from_ascii and name::from_utf8
d80377d add some IDNA tests for zone files and resolver
5c2314a fix compatibility tests
88e2f08 fix label encoding of \. for email addresses
5e9d820 cleanup from_labels usage
aa14466 cleanup benches
28ff463 add to_ascii and to_utf8 to Name and Label

📊 Changes

45 files changed (+1123 additions, -548 deletions)

View changed files

📝 Cargo.lock (+3 -1)
📝 client/benches/lower_name_benches.rs (+0 -1)
📝 client/src/client/client.rs (+11 -11)
📝 client/src/client/client_future.rs (+10 -10)
📝 client/src/rr/lower_name.rs (+21 -40)
📝 client/src/rr/mod.rs (+1 -1)
📝 compatibility-tests/tests/sig0_tests.rs (+5 -4)
📝 integration-tests/tests/authority_tests.rs (+10 -9)
📝 integration-tests/tests/client_future_tests.rs (+21 -22)
📝 integration-tests/tests/client_tests.rs (+23 -24)
📝 integration-tests/tests/lookup_tests.rs (+39 -40)
📝 integration-tests/tests/name_server_pool_tests.rs (+4 -5)
📝 integration-tests/tests/secure_client_handle_tests.rs (+7 -6)
📝 integration-tests/tests/server_future_tests.rs (+1 -1)
📝 proto/Cargo.toml (+2 -0)
📝 proto/benches/name_benches.rs (+33 -34)
📝 proto/src/lib.rs (+1 -0)
📝 proto/src/op/query.rs (+1 -1)
📝 proto/src/rr/dnssec/nsec3.rs (+3 -1)
📝 proto/src/rr/dnssec/rdata/nsec.rs (+2 -1)

...and 25 more files

📄 Description

fixes #321
fixes #139

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/325 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 1/4/2018 **Status:** ✅ Merged **Merged:** 1/14/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `support-punycode` --- ### 📝 Commits (9) - [`3129e97`](https://github.com/hickory-dns/hickory-dns/commit/3129e97405ea02ed15b27f4911589e147c25a6d7) fixup Name and Label to support punycode - [`95e3557`](https://github.com/hickory-dns/hickory-dns/commit/95e35576f7a1d4cf754750538ddf33838c6f4d42) add strict methods on Label for conversions - [`a349a18`](https://github.com/hickory-dns/hickory-dns/commit/a349a182a2d2c7a6c53802d860ba5a63cfefc62b) add name::from_ascii and name::from_utf8 - [`d80377d`](https://github.com/hickory-dns/hickory-dns/commit/d80377dc1f977ae3bff868ededc7a14752919c80) add some IDNA tests for zone files and resolver - [`5c2314a`](https://github.com/hickory-dns/hickory-dns/commit/5c2314a70e0481a4b3897c296b9fecbd03cb0811) fix compatibility tests - [`88e2f08`](https://github.com/hickory-dns/hickory-dns/commit/88e2f0886566944837fad21d782ac6a9d172d0f5) fix label encoding of \\. for email addresses - [`5e9d820`](https://github.com/hickory-dns/hickory-dns/commit/5e9d820860d25aa5dff2c59dfeaff631bd9f5c52) cleanup from_labels usage - [`aa14466`](https://github.com/hickory-dns/hickory-dns/commit/aa144667251558b76a272804d605a5b85b08ba33) cleanup benches - [`28ff463`](https://github.com/hickory-dns/hickory-dns/commit/28ff4631411e0cbadb4330807e9bddb1dbe4916c) add to_ascii and to_utf8 to Name and Label ### 📊 Changes **45 files changed** (+1123 additions, -548 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+3 -1) 📝 `client/benches/lower_name_benches.rs` (+0 -1) 📝 `client/src/client/client.rs` (+11 -11) 📝 `client/src/client/client_future.rs` (+10 -10) 📝 `client/src/rr/lower_name.rs` (+21 -40) 📝 `client/src/rr/mod.rs` (+1 -1) 📝 `compatibility-tests/tests/sig0_tests.rs` (+5 -4) 📝 `integration-tests/tests/authority_tests.rs` (+10 -9) 📝 `integration-tests/tests/client_future_tests.rs` (+21 -22) 📝 `integration-tests/tests/client_tests.rs` (+23 -24) 📝 `integration-tests/tests/lookup_tests.rs` (+39 -40) 📝 `integration-tests/tests/name_server_pool_tests.rs` (+4 -5) 📝 `integration-tests/tests/secure_client_handle_tests.rs` (+7 -6) 📝 `integration-tests/tests/server_future_tests.rs` (+1 -1) 📝 `proto/Cargo.toml` (+2 -0) 📝 `proto/benches/name_benches.rs` (+33 -34) 📝 `proto/src/lib.rs` (+1 -0) 📝 `proto/src/op/query.rs` (+1 -1) 📝 `proto/src/rr/dnssec/nsec3.rs` (+3 -1) 📝 `proto/src/rr/dnssec/rdata/nsec.rs` (+2 -1) _...and 25 more files_ </details> ### 📄 Description fixes #321 fixes #139 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>