[PR #289] [MERGED] switch to clap for the CLI options in Server #1348

New issue

Closed

opened 2026-03-16 02:01:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:01:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/289
Author: @bluejekyll
Created: 11/19/2017
Status: ✅ Merged
Merged: 11/24/2017
Merged by: @bluejekyll

Base: master ← Head: switch_to_clap

📝 Commits (6)

7c7b669 switch to clap, clean up logging
15fb643 fix tests
e21a2c9 cleanup optional colors
812482b remove the colored output
725d647 add time to loglines
17741b1 Merge branch 'master' into switch_to_clap

📊 Changes

11 files changed (+287 additions, -280 deletions)

View changed files

📝 Cargo.lock (+55 -135)
📝 client/src/lib.rs (+0 -8)
➖ client/src/logger.rs (+0 -54)
📝 integration-tests/tests/client_future_tests.rs (+0 -8)
📝 server/Cargo.toml (+2 -1)
📝 server/benches/comparison_benches.rs (+2 -2)
📝 server/src/lib.rs (+6 -4)
➕ server/src/logger.rs (+87 -0)
📝 server/src/named.rs (+109 -52)
📝 server/tests/server_harness/mod.rs (+26 -12)
📝 server/tests/z_named_tests.rs (+0 -4)

📄 Description

This also enables some optional colorization of the logs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/289 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 11/19/2017 **Status:** ✅ Merged **Merged:** 11/24/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `switch_to_clap` --- ### 📝 Commits (6) - [`7c7b669`](https://github.com/hickory-dns/hickory-dns/commit/7c7b6690c51ed8bd59e7967ef714f1c38b5dafbf) switch to clap, clean up logging - [`15fb643`](https://github.com/hickory-dns/hickory-dns/commit/15fb643c3c9b35f2b518df33aacb1e807e417b7b) fix tests - [`e21a2c9`](https://github.com/hickory-dns/hickory-dns/commit/e21a2c9789a1d827af09dc1dd0c00de8d726b4a0) cleanup optional colors - [`812482b`](https://github.com/hickory-dns/hickory-dns/commit/812482bb3fdcdde849d4ec0c801303cc6e1a9842) remove the colored output - [`725d647`](https://github.com/hickory-dns/hickory-dns/commit/725d6471d69179ed834d900c204947bb6e147f4f) add time to loglines - [`17741b1`](https://github.com/hickory-dns/hickory-dns/commit/17741b1dda209ae6a79f9e6012027ed86551f674) Merge branch 'master' into switch_to_clap ### 📊 Changes **11 files changed** (+287 additions, -280 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+55 -135) 📝 `client/src/lib.rs` (+0 -8) ➖ `client/src/logger.rs` (+0 -54) 📝 `integration-tests/tests/client_future_tests.rs` (+0 -8) 📝 `server/Cargo.toml` (+2 -1) 📝 `server/benches/comparison_benches.rs` (+2 -2) 📝 `server/src/lib.rs` (+6 -4) ➕ `server/src/logger.rs` (+87 -0) 📝 `server/src/named.rs` (+109 -52) 📝 `server/tests/server_harness/mod.rs` (+26 -12) 📝 `server/tests/z_named_tests.rs` (+0 -4) </details> ### 📄 Description This also enables some optional colorization of the logs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>