[PR #292] [MERGED] Properly include u16::max in rand Id generation #1346

New issue

Closed

opened 2026-03-16 02:01:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:01:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/292
Author: @bluejekyll
Created: 11/22/2017
Status: ✅ Merged
Merged: 11/24/2017
Merged by: @bluejekyll

Base: master ← Head: fix_rand_usage2

📝 Commits (3)

7d5d5ec include max value for u16 in rand for id generation
1de3bf5 also fix rand generation for UDP src port
7961acc Merge branch 'master' into fix_rand_usage2

📊 Changes

2 files changed (+11 additions, -8 deletions)

View changed files

📝 proto/src/dns_handle.rs (+2 -2)
📝 proto/src/udp/udp_stream.rs (+9 -6)

📄 Description

properly fixes #253

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/292 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 11/22/2017 **Status:** ✅ Merged **Merged:** 11/24/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix_rand_usage2` --- ### 📝 Commits (3) - [`7d5d5ec`](https://github.com/hickory-dns/hickory-dns/commit/7d5d5ec51d7b4240ceabc4bf60a67e67afb13355) include max value for u16 in rand for id generation - [`1de3bf5`](https://github.com/hickory-dns/hickory-dns/commit/1de3bf5ac6878b3fb322c9d681b25331f951d7cf) also fix rand generation for UDP src port - [`7961acc`](https://github.com/hickory-dns/hickory-dns/commit/7961acc8860e11ee0642b54232e1cf5112f1b2c3) Merge branch 'master' into fix_rand_usage2 ### 📊 Changes **2 files changed** (+11 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `proto/src/dns_handle.rs` (+2 -2) 📝 `proto/src/udp/udp_stream.rs` (+9 -6) </details> ### 📄 Description properly fixes #253 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>