[PR #286] [MERGED] Fix NxDomain and NoData responses #1344

New issue

Closed

opened 2026-03-16 02:01:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:01:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/286
Author: @bluejekyll
Created: 11/13/2017
Status: ✅ Merged
Merged: 11/21/2017
Merged by: @bluejekyll

Base: master ← Head: fix_nxdomain

📝 Commits (10+)

0c7ceed fix NxDomain and NoData responses
99a88b7 fix test compilation
77f6d1b add nxdomain and nodata tests
0a2c5f5 add better logs for requests
4eebc15 fix NSEC records to be NoError
1250e99 add dnssec to request log
f1ea053 add message length to logs
9b3d1ce fix nsec tests to expect NoError
0508937 enforce consistent and correct order on nsec bitmap
df1453a Merge branch 'master' into fix_nxdomain

📊 Changes

12 files changed (+464 additions, -191 deletions)

View changed files

📝 integration-tests/tests/authority_tests.rs (+25 -23)
📝 integration-tests/tests/secure_client_handle_tests.rs (+1 -1)
📝 proto/src/rr/dnssec/rdata/nsec3.rs (+5 -3)
📝 proto/src/rr/rr_key.rs (+5 -0)
➕ server/src/authority/auth_lookup.rs (+64 -0)
📝 server/src/authority/authority.rs (+126 -77)
📝 server/src/authority/catalog.rs (+37 -21)
📝 server/src/authority/mod.rs (+2 -0)
📝 server/src/server/request_stream.rs (+12 -2)
📝 server/src/server/server_future.rs (+81 -54)
📝 server/tests/txt_tests.rs (+55 -10)
📝 server/tests/z_named_tests.rs (+51 -0)

📄 Description

fixes: #53

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/286 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 11/13/2017 **Status:** ✅ Merged **Merged:** 11/21/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix_nxdomain` --- ### 📝 Commits (10+) - [`0c7ceed`](https://github.com/hickory-dns/hickory-dns/commit/0c7ceed344da2b79f6d85d865479fd59bd6ad907) fix NxDomain and NoData responses - [`99a88b7`](https://github.com/hickory-dns/hickory-dns/commit/99a88b720ef15e6e417409291852d74ed0a30c6b) fix test compilation - [`77f6d1b`](https://github.com/hickory-dns/hickory-dns/commit/77f6d1b935b3c71405c94d7d2e049ef80f9ff7f7) add nxdomain and nodata tests - [`0a2c5f5`](https://github.com/hickory-dns/hickory-dns/commit/0a2c5f5f74de4585634ea2ee42895e972c979166) add better logs for requests - [`4eebc15`](https://github.com/hickory-dns/hickory-dns/commit/4eebc1533f9c419be81647d3304cc253a4b51f79) fix NSEC records to be NoError - [`1250e99`](https://github.com/hickory-dns/hickory-dns/commit/1250e99a15e234ff7575b310553c4622afad8685) add dnssec to request log - [`f1ea053`](https://github.com/hickory-dns/hickory-dns/commit/f1ea0534597f27d24317f8803b004e726cb9245d) add message length to logs - [`9b3d1ce`](https://github.com/hickory-dns/hickory-dns/commit/9b3d1cee86b79e1432a14298ac54648125351f6f) fix nsec tests to expect NoError - [`0508937`](https://github.com/hickory-dns/hickory-dns/commit/05089370da2a376bb1930635e3f87a80e34104bd) enforce consistent and correct order on nsec bitmap - [`df1453a`](https://github.com/hickory-dns/hickory-dns/commit/df1453a46cc2c9135e805dc6f4008ace9f22082f) Merge branch 'master' into fix_nxdomain ### 📊 Changes **12 files changed** (+464 additions, -191 deletions) <details> <summary>View changed files</summary> 📝 `integration-tests/tests/authority_tests.rs` (+25 -23) 📝 `integration-tests/tests/secure_client_handle_tests.rs` (+1 -1) 📝 `proto/src/rr/dnssec/rdata/nsec3.rs` (+5 -3) 📝 `proto/src/rr/rr_key.rs` (+5 -0) ➕ `server/src/authority/auth_lookup.rs` (+64 -0) 📝 `server/src/authority/authority.rs` (+126 -77) 📝 `server/src/authority/catalog.rs` (+37 -21) 📝 `server/src/authority/mod.rs` (+2 -0) 📝 `server/src/server/request_stream.rs` (+12 -2) 📝 `server/src/server/server_future.rs` (+81 -54) 📝 `server/tests/txt_tests.rs` (+55 -10) 📝 `server/tests/z_named_tests.rs` (+51 -0) </details> ### 📄 Description fixes: #53 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>