[PR #288] [MERGED] clippy fixes #1343

New issue

Closed

opened 2026-03-16 02:01:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:01:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/288
Author: @little-dude
Created: 11/19/2017
Status: ✅ Merged
Merged: 11/23/2017
Merged by: @bluejekyll

Base: master ← Head: clippy

📝 Commits (1)

6fa9d4a clippy fixes for client and proto crates

📊 Changes

62 files changed (+445 additions, -384 deletions)

View changed files

📝 .travis.yml (+5 -3)
📝 client/src/client/client.rs (+3 -3)
📝 client/src/client/memoize_client_handle.rs (+1 -1)
📝 client/src/client/rc_future.rs (+5 -5)
📝 client/src/error/client_error.rs (+5 -5)
📝 client/src/rr/dnssec/key_format.rs (+26 -26)
📝 client/src/rr/dnssec/keypair.rs (+9 -19)
📝 client/src/rr/dnssec/signer.rs (+2 -2)
📝 client/src/serialize/txt/master.rs (+13 -11)
📝 client/src/serialize/txt/master_lex.rs (+22 -22)
📝 client/src/serialize/txt/rdata_parsers/a.rs (+1 -1)
📝 client/src/serialize/txt/rdata_parsers/aaaa.rs (+1 -1)
📝 client/src/serialize/txt/rdata_parsers/mx.rs (+2 -2)
📝 client/src/serialize/txt/rdata_parsers/name.rs (+1 -1)
📝 client/src/serialize/txt/rdata_parsers/soa.rs (+7 -7)
📝 client/src/serialize/txt/rdata_parsers/srv.rs (+4 -4)
📝 client/src/serialize/txt/rdata_parsers/tlsa.rs (+1 -1)
📝 integration-tests/tests/client_future_tests.rs (+10 -10)
📝 integration-tests/tests/secure_client_handle_tests.rs (+1 -1)
📝 proto/src/dns_handle.rs (+5 -5)

...and 42 more files

📄 Description

I'm interested in starting contributing to trust-dns, and clippy is a good way to get a little bit familiar with the codebase, so here we go :)

With these fixes the client builds with clippy with no warning:

~/r/t/client ❯❯❯ cargo clippy -- --allow doc_markdown  --allow type_complexity --allow module_inception --allow new_ret_no_self 
   Compiling trust-dns v0.12.0 (file:///home/little-dude/rust/trust-dns/client)
    Finished dev [unoptimized + debuginfo] target(s) in 3.54 secs

Let me know if you're interested in more clippy fixes. While on topic of cosmetic changes, I noticed you use try!. Do you plan to move to ? at some point or do you prefer try!? If so I can make a PR for that.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/288 **Author:** [@little-dude](https://github.com/little-dude) **Created:** 11/19/2017 **Status:** ✅ Merged **Merged:** 11/23/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `clippy` --- ### 📝 Commits (1) - [`6fa9d4a`](https://github.com/hickory-dns/hickory-dns/commit/6fa9d4a322cb39c2237ab9f96ece26abd8e87597) clippy fixes for client and proto crates ### 📊 Changes **62 files changed** (+445 additions, -384 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+5 -3) 📝 `client/src/client/client.rs` (+3 -3) 📝 `client/src/client/memoize_client_handle.rs` (+1 -1) 📝 `client/src/client/rc_future.rs` (+5 -5) 📝 `client/src/error/client_error.rs` (+5 -5) 📝 `client/src/rr/dnssec/key_format.rs` (+26 -26) 📝 `client/src/rr/dnssec/keypair.rs` (+9 -19) 📝 `client/src/rr/dnssec/signer.rs` (+2 -2) 📝 `client/src/serialize/txt/master.rs` (+13 -11) 📝 `client/src/serialize/txt/master_lex.rs` (+22 -22) 📝 `client/src/serialize/txt/rdata_parsers/a.rs` (+1 -1) 📝 `client/src/serialize/txt/rdata_parsers/aaaa.rs` (+1 -1) 📝 `client/src/serialize/txt/rdata_parsers/mx.rs` (+2 -2) 📝 `client/src/serialize/txt/rdata_parsers/name.rs` (+1 -1) 📝 `client/src/serialize/txt/rdata_parsers/soa.rs` (+7 -7) 📝 `client/src/serialize/txt/rdata_parsers/srv.rs` (+4 -4) 📝 `client/src/serialize/txt/rdata_parsers/tlsa.rs` (+1 -1) 📝 `integration-tests/tests/client_future_tests.rs` (+10 -10) 📝 `integration-tests/tests/secure_client_handle_tests.rs` (+1 -1) 📝 `proto/src/dns_handle.rs` (+5 -5) _...and 42 more files_ </details> ### 📄 Description I'm interested in starting contributing to trust-dns, and clippy is a good way to get a little bit familiar with the codebase, so here we go :) With these fixes the client builds with clippy with no warning: ``` ~/r/t/client ❯❯❯ cargo clippy -- --allow doc_markdown --allow type_complexity --allow module_inception --allow new_ret_no_self Compiling trust-dns v0.12.0 (file:///home/little-dude/rust/trust-dns/client) Finished dev [unoptimized + debuginfo] target(s) in 3.54 secs ``` Let me know if you're interested in more clippy fixes. While on topic of cosmetic changes, I noticed you use `try!`. Do you plan to move to `?` at some point or do you prefer `try!`? If so I can make a PR for that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>