[PR #285] [MERGED] Support for TLSA #1342

New issue

Closed

opened 2026-03-16 02:01:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:01:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/285
Author: @bluejekyll
Created: 11/10/2017
Status: ✅ Merged
Merged: 11/12/2017
Merged by: @bluejekyll

Base: master ← Head: support_tlsa

📝 Commits (9)

3ba4a0f add binary parsers for TLSA
f33588c Merge branch 'master' into support_tlsa
b20c390 binary tests for TLSA
2556320 master file parsing for TLSA
8379a13 simplify text record parsing
ce438bc tlsa tests
9f8d0f8 add some additional tests to TLSA and CAA
f507a6e fix the parsing tests for CAA and TLSA
ccff9e4 clean up some unneeded comments

📊 Changes

24 files changed (+784 additions, -249 deletions)

View changed files

📝 README.md (+1 -0)
📝 client/src/error/parse_error.rs (+1 -0)
📝 client/src/lib.rs (+0 -1)
📝 client/src/rr/dnssec/signer.rs (+1 -0)
📝 client/src/serialize/txt/master.rs (+40 -33)
📝 client/src/serialize/txt/parse_rdata.rs (+27 -14)
📝 client/src/serialize/txt/rdata_parsers/a.rs (+5 -12)
📝 client/src/serialize/txt/rdata_parsers/aaaa.rs (+5 -12)
📝 client/src/serialize/txt/rdata_parsers/caa.rs (+20 -23)
📝 client/src/serialize/txt/rdata_parsers/mod.rs (+1 -0)
📝 client/src/serialize/txt/rdata_parsers/mx.rs (+14 -26)
📝 client/src/serialize/txt/rdata_parsers/name.rs (+7 -12)
📝 client/src/serialize/txt/rdata_parsers/null.rs (+1 -2)
📝 client/src/serialize/txt/rdata_parsers/soa.rs (+29 -53)
📝 client/src/serialize/txt/rdata_parsers/srv.rs (+23 -40)
➕ client/src/serialize/txt/rdata_parsers/tlsa.rs (+93 -0)
📝 client/src/serialize/txt/rdata_parsers/txt.rs (+2 -10)
📝 native-tls/src/tls_stream.rs (+1 -1)
📝 proto/src/rr/rdata/mod.rs (+2 -0)
➕ proto/src/rr/rdata/tlsa.rs (+446 -0)

...and 4 more files

📄 Description

fixes #235

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/285 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 11/10/2017 **Status:** ✅ Merged **Merged:** 11/12/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `support_tlsa` --- ### 📝 Commits (9) - [`3ba4a0f`](https://github.com/hickory-dns/hickory-dns/commit/3ba4a0f5e1d3c10bd144185af35197000dafdde6) add binary parsers for TLSA - [`f33588c`](https://github.com/hickory-dns/hickory-dns/commit/f33588c799cee3e152a0566aca535cda97cb2086) Merge branch 'master' into support_tlsa - [`b20c390`](https://github.com/hickory-dns/hickory-dns/commit/b20c390efd277074405a86ef75e510a2da89bf57) binary tests for TLSA - [`2556320`](https://github.com/hickory-dns/hickory-dns/commit/2556320807f848852d5d30958afab288fe210ee4) master file parsing for TLSA - [`8379a13`](https://github.com/hickory-dns/hickory-dns/commit/8379a131771e44ffcb73cef6a2a29554e1881fb9) simplify text record parsing - [`ce438bc`](https://github.com/hickory-dns/hickory-dns/commit/ce438bcb37b36060bd7fc060c579c945d6b7d853) tlsa tests - [`9f8d0f8`](https://github.com/hickory-dns/hickory-dns/commit/9f8d0f8b9c29506ab868d5a1c74e5c82cc99f6ae) add some additional tests to TLSA and CAA - [`f507a6e`](https://github.com/hickory-dns/hickory-dns/commit/f507a6e03a27d7361000ecd70e12023de3aa144c) fix the parsing tests for CAA and TLSA - [`ccff9e4`](https://github.com/hickory-dns/hickory-dns/commit/ccff9e43e7cd835a7eeadfbdf474489d078cb6cf) clean up some unneeded comments ### 📊 Changes **24 files changed** (+784 additions, -249 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -0) 📝 `client/src/error/parse_error.rs` (+1 -0) 📝 `client/src/lib.rs` (+0 -1) 📝 `client/src/rr/dnssec/signer.rs` (+1 -0) 📝 `client/src/serialize/txt/master.rs` (+40 -33) 📝 `client/src/serialize/txt/parse_rdata.rs` (+27 -14) 📝 `client/src/serialize/txt/rdata_parsers/a.rs` (+5 -12) 📝 `client/src/serialize/txt/rdata_parsers/aaaa.rs` (+5 -12) 📝 `client/src/serialize/txt/rdata_parsers/caa.rs` (+20 -23) 📝 `client/src/serialize/txt/rdata_parsers/mod.rs` (+1 -0) 📝 `client/src/serialize/txt/rdata_parsers/mx.rs` (+14 -26) 📝 `client/src/serialize/txt/rdata_parsers/name.rs` (+7 -12) 📝 `client/src/serialize/txt/rdata_parsers/null.rs` (+1 -2) 📝 `client/src/serialize/txt/rdata_parsers/soa.rs` (+29 -53) 📝 `client/src/serialize/txt/rdata_parsers/srv.rs` (+23 -40) ➕ `client/src/serialize/txt/rdata_parsers/tlsa.rs` (+93 -0) 📝 `client/src/serialize/txt/rdata_parsers/txt.rs` (+2 -10) 📝 `native-tls/src/tls_stream.rs` (+1 -1) 📝 `proto/src/rr/rdata/mod.rs` (+2 -0) ➕ `proto/src/rr/rdata/tlsa.rs` (+446 -0) _...and 4 more files_ </details> ### 📄 Description fixes #235 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>