[PR #281] [MERGED] Client: Don't make dnssec-openssl a default feature (breaking change). #1337

New issue

Closed

opened 2026-03-16 02:01:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:01:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/281
Author: @briansmith
Created: 11/2/2017
Status: ✅ Merged
Merged: 11/2/2017
Merged by: @bluejekyll

Base: master ← Head: b/client-no-default-dnssec-openssl

📝 Commits (2)

479faa7 Client: Don't make dnssec-openssl a default feature (breaking change).
5ba88ba fix compat tests

📊 Changes

3 files changed (+2 additions, -4 deletions)

View changed files

📝 client/Cargo.toml (+0 -1)
📝 compatibility-tests/Cargo.toml (+1 -2)
📝 server/Cargo.toml (+1 -1)

📄 Description

It is too easy to accidentally add the dnssec-openssl feature when it
wasn't intended when it is a default feature. This was happening in
trust-dns-server, for example.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/281 **Author:** [@briansmith](https://github.com/briansmith) **Created:** 11/2/2017 **Status:** ✅ Merged **Merged:** 11/2/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `b/client-no-default-dnssec-openssl` --- ### 📝 Commits (2) - [`479faa7`](https://github.com/hickory-dns/hickory-dns/commit/479faa7095ee695a7fbf3f8e02bdd1f46b6a788b) Client: Don't make dnssec-openssl a default feature (breaking change). - [`5ba88ba`](https://github.com/hickory-dns/hickory-dns/commit/5ba88ba5982705b7c3aa3f99f46fa772058b528c) fix compat tests ### 📊 Changes **3 files changed** (+2 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `client/Cargo.toml` (+0 -1) 📝 `compatibility-tests/Cargo.toml` (+1 -2) 📝 `server/Cargo.toml` (+1 -1) </details> ### 📄 Description It is too easy to accidentally add the dnssec-openssl feature when it wasn't intended when it is a default feature. This was happening in trust-dns-server, for example. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>