[PR #248] [MERGED] Allow disabling the ipconfig dependency. #1325

New issue

Closed

opened 2026-03-16 02:00:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:00:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/248
Author: @briansmith
Created: 10/24/2017
Status: ✅ Merged
Merged: 10/25/2017
Merged by: @bluejekyll

Base: master ← Head: allow-skipping-ipconfig

📝 Commits (2)

8e74b75 Allow disabling the ipconfig dependency.
e1b8375 Merge branch 'master' into allow-skipping-ipconfig

📊 Changes

5 files changed (+15 additions, -13 deletions)

View changed files

📝 resolver/Cargo.toml (+2 -2)
📝 resolver/src/lib.rs (+1 -1)
📝 resolver/src/resolver.rs (+5 -4)
📝 resolver/src/resolver_future.rs (+5 -4)
📝 resolver/src/system_conf/mod.rs (+2 -2)

📄 Description

If one doesn't need the ipconfig functionality then the ipconfig
dependency is a overly-heavy and overly-risky dependency. Allow users
to disable the feature to avoid the dependency.

In particular, ipconfig seems to require clang.dll and has trouble
finding it on my system, which means that I cannot actually use
Trust-DNS on Windows when ipconfig is enabled. Of course, that should
be fixed in ipconfig, but for people won't need it's functionality,
this is a much simpler and more bulletproof workaround.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/248 **Author:** [@briansmith](https://github.com/briansmith) **Created:** 10/24/2017 **Status:** ✅ Merged **Merged:** 10/25/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `allow-skipping-ipconfig` --- ### 📝 Commits (2) - [`8e74b75`](https://github.com/hickory-dns/hickory-dns/commit/8e74b751d5b590b154f8274175cee28200da5078) Allow disabling the ipconfig dependency. - [`e1b8375`](https://github.com/hickory-dns/hickory-dns/commit/e1b8375295b525bdef7c6b6a220e9caf8dba469e) Merge branch 'master' into allow-skipping-ipconfig ### 📊 Changes **5 files changed** (+15 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `resolver/Cargo.toml` (+2 -2) 📝 `resolver/src/lib.rs` (+1 -1) 📝 `resolver/src/resolver.rs` (+5 -4) 📝 `resolver/src/resolver_future.rs` (+5 -4) 📝 `resolver/src/system_conf/mod.rs` (+2 -2) </details> ### 📄 Description If one doesn't need the ipconfig functionality then the ipconfig dependency is a overly-heavy and overly-risky dependency. Allow users to disable the feature to avoid the dependency. In particular, ipconfig seems to require clang.dll and has trouble finding it on my system, which means that I cannot actually use Trust-DNS on Windows when ipconfig is enabled. Of course, that should be fixed in ipconfig, but for people won't need it's functionality, this is a much simpler and more bulletproof workaround. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>