[PR #259] [MERGED] Move `Algorithm::from_str()`'s logic from -proto to -server. #1323

New issue

Closed

opened 2026-03-16 02:00:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:00:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/259
Author: @briansmith
Created: 10/24/2017
Status: ✅ Merged
Merged: 10/25/2017
Merged by: @bluejekyll

Base: master ← Head: remove-Algorithm-from_str

📝 Commits (3)

5956efa Move Algorithm::from_str()'s logic from -proto to -server.
aec6258 Merge branch 'master' into remove-Algorithm-from_str
2738233 Merge branch 'master' into remove-Algorithm-from_str

📊 Changes

2 files changed (+10 additions, -21 deletions)

View changed files

📝 proto/src/rr/dnssec/algorithm.rs (+0 -20)
📝 server/src/config.rs (+10 -1)

📄 Description

Algorithm::from_str() isn't uesd by -resolver so it shouldn't be in
-proto.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/259 **Author:** [@briansmith](https://github.com/briansmith) **Created:** 10/24/2017 **Status:** ✅ Merged **Merged:** 10/25/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `remove-Algorithm-from_str` --- ### 📝 Commits (3) - [`5956efa`](https://github.com/hickory-dns/hickory-dns/commit/5956efa5084426e1460bc23b7171adc5d6c6a571) Move `Algorithm::from_str()`'s logic from -proto to -server. - [`aec6258`](https://github.com/hickory-dns/hickory-dns/commit/aec6258e67b0a660acc1a350182c7f8503678e65) Merge branch 'master' into remove-Algorithm-from_str - [`2738233`](https://github.com/hickory-dns/hickory-dns/commit/2738233b0a751fbdc71a5dcd429b293af93f9616) Merge branch 'master' into remove-Algorithm-from_str ### 📊 Changes **2 files changed** (+10 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `proto/src/rr/dnssec/algorithm.rs` (+0 -20) 📝 `server/src/config.rs` (+10 -1) </details> ### 📄 Description `Algorithm::from_str()` isn't uesd by -resolver so it shouldn't be in -proto. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>