[PR #245] [MERGED] Make Client and Resolver Send + Sync #1318

New issue

Closed

opened 2026-03-16 01:59:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:59:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/245
Author: @bluejekyll
Created: 10/24/2017
Status: ✅ Merged
Merged: 11/1/2017
Merged by: @bluejekyll

Base: master ← Head: make-client-send

📝 Commits (10+)

c5ea2e0 resolver is sendable
1514907 Client and SyncClient now Clone and Send
278debf share cache across clones of sync Resolver
5acf9b3 assert Client and SyncClient are send and sync
dd9a200 remove explicit ClientConnection and Client send+sync requirements
19b4888 rusls send + sync
7c400d6 fix type of messagefinalizer
a774b5a everything compiling
2ae1ab7 use rustls for client side validation of server
1801c04 fix client when all features disabled

📊 Changes

37 files changed (+456 additions, -681 deletions)

View changed files

📝 CHANGELOG.md (+5 -0)
📝 Cargo.lock (+2 -0)
📝 client/src/client/client.rs (+144 -143)
📝 client/src/client/client_connection.rs (+2 -4)
📝 client/src/client/client_future.rs (+3 -2)
📝 client/src/rr/dnssec/signer.rs (+10 -0)
📝 client/src/tcp/tcp_client_connection.rs (+19 -20)
📝 client/src/udp/udp_client_connection.rs (+15 -21)
📝 compatibility-tests/tests/sig0_tests.rs (+1 -1)
📝 integration-tests/Cargo.toml (+2 -0)
📝 integration-tests/src/lib.rs (+11 -20)
📝 integration-tests/tests/client_future_tests.rs (+5 -4)
📝 integration-tests/tests/client_tests.rs (+39 -77)
📝 integration-tests/tests/lookup_tests.rs (+14 -4)
📝 integration-tests/tests/secure_client_handle_tests.rs (+2 -1)
📝 integration-tests/tests/server_future_tests.rs (+28 -74)
📝 native-tls/src/lib.rs (+0 -2)
📝 native-tls/src/tests.rs (+2 -2)
➖ native-tls/src/tls_client_connection.rs (+0 -104)
📝 native-tls/src/tls_client_stream.rs (+3 -3)

...and 17 more files

📄 Description

Fixes #227

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/245 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 10/24/2017 **Status:** ✅ Merged **Merged:** 11/1/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `make-client-send` --- ### 📝 Commits (10+) - [`c5ea2e0`](https://github.com/hickory-dns/hickory-dns/commit/c5ea2e0e282c95534262bc060913419b2bf17add) resolver is sendable - [`1514907`](https://github.com/hickory-dns/hickory-dns/commit/151490724b9c450e49541e6c69df54f2a90c6990) Client and SyncClient now Clone and Send - [`278debf`](https://github.com/hickory-dns/hickory-dns/commit/278debf68c6bc55c98ab8b170c332bc2b5fe5f51) share cache across clones of sync Resolver - [`5acf9b3`](https://github.com/hickory-dns/hickory-dns/commit/5acf9b3c9ab56fc1fd6a3d7302572434ef871602) assert Client and SyncClient are send and sync - [`dd9a200`](https://github.com/hickory-dns/hickory-dns/commit/dd9a20064e3eafddd3044c7e25e49cd1991e4c84) remove explicit ClientConnection and Client send+sync requirements - [`19b4888`](https://github.com/hickory-dns/hickory-dns/commit/19b4888771acaf5585bd1c0e502b45441c269ad6) rusls send + sync - [`7c400d6`](https://github.com/hickory-dns/hickory-dns/commit/7c400d6ca50b48bb908042d85e7eac23f44ced9a) fix type of messagefinalizer - [`a774b5a`](https://github.com/hickory-dns/hickory-dns/commit/a774b5ac4ca6b48c2d47687a0682bdb949911fb0) everything compiling - [`2ae1ab7`](https://github.com/hickory-dns/hickory-dns/commit/2ae1ab753ab48121fb7d2b2ae9033ba41c259a22) use rustls for client side validation of server - [`1801c04`](https://github.com/hickory-dns/hickory-dns/commit/1801c04b37b9380979278e8e98e80488b3f3c18f) fix client when all features disabled ### 📊 Changes **37 files changed** (+456 additions, -681 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+5 -0) 📝 `Cargo.lock` (+2 -0) 📝 `client/src/client/client.rs` (+144 -143) 📝 `client/src/client/client_connection.rs` (+2 -4) 📝 `client/src/client/client_future.rs` (+3 -2) 📝 `client/src/rr/dnssec/signer.rs` (+10 -0) 📝 `client/src/tcp/tcp_client_connection.rs` (+19 -20) 📝 `client/src/udp/udp_client_connection.rs` (+15 -21) 📝 `compatibility-tests/tests/sig0_tests.rs` (+1 -1) 📝 `integration-tests/Cargo.toml` (+2 -0) 📝 `integration-tests/src/lib.rs` (+11 -20) 📝 `integration-tests/tests/client_future_tests.rs` (+5 -4) 📝 `integration-tests/tests/client_tests.rs` (+39 -77) 📝 `integration-tests/tests/lookup_tests.rs` (+14 -4) 📝 `integration-tests/tests/secure_client_handle_tests.rs` (+2 -1) 📝 `integration-tests/tests/server_future_tests.rs` (+28 -74) 📝 `native-tls/src/lib.rs` (+0 -2) 📝 `native-tls/src/tests.rs` (+2 -2) ➖ `native-tls/src/tls_client_connection.rs` (+0 -104) 📝 `native-tls/src/tls_client_stream.rs` (+3 -3) _...and 17 more files_ </details> ### 📄 Description Fixes #227 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>