[PR #239] [MERGED] Resolver refactored on top of Proto (off Client) #1317

New issue

Closed

opened 2026-03-16 01:59:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:59:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/239
Author: @bluejekyll
Created: 10/17/2017
Status: ✅ Merged
Merged: 10/24/2017
Merged by: @bluejekyll

Base: master ← Head: resolver-to-proto

📝 Commits (10+)

193a424 fix Readme with Proto reference.
f42f353 wip: Need to move SecureClientHandle and RetryClientHandle
8fbc612 move Resolver to Proto
4acbaf9 remove unused proto errors
9bba035 remove unused errors from Client
ccfc9aa rename NoRecordFound to NoRecordsFound
c807e6b reword Readme for Proto library
976a274 remove commented out errors
0c3ba47 remove old client error types
0594c2f generified types for errors in streams

📊 Changes

61 files changed (+697 additions, -806 deletions)

View changed files

📝 Cargo.lock (+0 -1)
📝 README.md (+1 -0)
📝 client/src/client/client_connection.rs (+3 -1)
📝 client/src/client/client_future.rs (+3 -3)
📝 client/src/error/client_error.rs (+0 -63)
➖ client/src/error/decode_error.rs (+0 -123)
📝 client/src/error/dnssec_error.rs (+0 -3)
➖ client/src/error/encode_error.rs (+0 -62)
📝 client/src/error/lexer_error.rs (+0 -10)
📝 client/src/error/mod.rs (+0 -10)
📝 client/src/error/parse_error.rs (+0 -2)
📝 client/src/lib.rs (+3 -9)
📝 client/src/tcp/tcp_client_connection.rs (+2 -2)
📝 client/src/udp/udp_client_connection.rs (+2 -2)
📝 integration-tests/src/lib.rs (+13 -10)
📝 integration-tests/src/mock_client.rs (+13 -13)
📝 integration-tests/tests/client_future_tests.rs (+4 -4)
📝 integration-tests/tests/client_tests.rs (+3 -2)
📝 integration-tests/tests/lookup_tests.rs (+13 -14)
📝 integration-tests/tests/name_server_pool_tests.rs (+9 -9)

...and 41 more files

📄 Description

Fixes #237

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/239 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 10/17/2017 **Status:** ✅ Merged **Merged:** 10/24/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `resolver-to-proto` --- ### 📝 Commits (10+) - [`193a424`](https://github.com/hickory-dns/hickory-dns/commit/193a424f6557ff7e5c860ac0bd2805733fc5174a) fix Readme with Proto reference. - [`f42f353`](https://github.com/hickory-dns/hickory-dns/commit/f42f353cfb250884d41f8bc80524daa7f51cfb35) wip: Need to move SecureClientHandle and RetryClientHandle - [`8fbc612`](https://github.com/hickory-dns/hickory-dns/commit/8fbc6125f95debf41d476d5eee9d6b679cd5f6d5) move Resolver to Proto - [`4acbaf9`](https://github.com/hickory-dns/hickory-dns/commit/4acbaf98cc2496a663b9bbe4f09579ba5636cefa) remove unused proto errors - [`9bba035`](https://github.com/hickory-dns/hickory-dns/commit/9bba035dd747e66fda4e81a691322c311c62fa1f) remove unused errors from Client - [`ccfc9aa`](https://github.com/hickory-dns/hickory-dns/commit/ccfc9aaea4b3de9cecec98f166025b30e83f0ea7) rename NoRecordFound to NoRecordsFound - [`c807e6b`](https://github.com/hickory-dns/hickory-dns/commit/c807e6b4c66c8ac6407d90ae19624e4338981a1c) reword Readme for Proto library - [`976a274`](https://github.com/hickory-dns/hickory-dns/commit/976a2746b33c9f6607e162b080d8586b4064fe54) remove commented out errors - [`0c3ba47`](https://github.com/hickory-dns/hickory-dns/commit/0c3ba47604c68f36cae75e305dd25cf3698fff7e) remove old client error types - [`0594c2f`](https://github.com/hickory-dns/hickory-dns/commit/0594c2f97e176c4e08853f6093055bf8aa358bb6) generified types for errors in streams ### 📊 Changes **61 files changed** (+697 additions, -806 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+0 -1) 📝 `README.md` (+1 -0) 📝 `client/src/client/client_connection.rs` (+3 -1) 📝 `client/src/client/client_future.rs` (+3 -3) 📝 `client/src/error/client_error.rs` (+0 -63) ➖ `client/src/error/decode_error.rs` (+0 -123) 📝 `client/src/error/dnssec_error.rs` (+0 -3) ➖ `client/src/error/encode_error.rs` (+0 -62) 📝 `client/src/error/lexer_error.rs` (+0 -10) 📝 `client/src/error/mod.rs` (+0 -10) 📝 `client/src/error/parse_error.rs` (+0 -2) 📝 `client/src/lib.rs` (+3 -9) 📝 `client/src/tcp/tcp_client_connection.rs` (+2 -2) 📝 `client/src/udp/udp_client_connection.rs` (+2 -2) 📝 `integration-tests/src/lib.rs` (+13 -10) 📝 `integration-tests/src/mock_client.rs` (+13 -13) 📝 `integration-tests/tests/client_future_tests.rs` (+4 -4) 📝 `integration-tests/tests/client_tests.rs` (+3 -2) 📝 `integration-tests/tests/lookup_tests.rs` (+13 -14) 📝 `integration-tests/tests/name_server_pool_tests.rs` (+9 -9) _...and 41 more files_ </details> ### 📄 Description Fixes #237 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>