[PR #218] [MERGED] Remove private key and certificate generation features from the server. #1306

New issue

Closed

opened 2026-03-16 01:59:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:59:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/218
Author: @briansmith
Created: 10/2/2017
Status: ✅ Merged
Merged: 10/3/2017
Merged by: @bluejekyll

Base: master ← Head: no-self-signed-certs

📝 Commits (3)

bd62757 Remove the create_if_absent TLS certificate feature.
4ea5bfe Remove create_if_absent DNSSEC key feature.
8f03ca3 Merge branch 'master' into no-self-signed-certs

📊 Changes

6 files changed (+7 additions, -175 deletions)

View changed files

📝 openssl/src/tls_server.rs (+0 -58)
📝 server/src/config.rs (+1 -21)
📝 server/src/named.rs (+3 -77)
📝 server/tests/config_tests.rs (+1 -10)
📝 server/tests/named_test_configs/dns_over_tls.toml (+1 -1)
📝 server/tests/named_test_configs/example.toml (+1 -8)

📄 Description

This is probably a controversial change. I don't fully understand the original motivation for the features being removed (and possibly later moved somewhere else). Consider this more of an RFC or a request for an explanation of which scenerios the features could reasonably be used for.

This is a step towards removing KeyPair::generate(), KeyPair::generate_pkcs(), and KeyFormat::generate_and_encode()`, once the use of those functions is removed from the unit tests, in a separate PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/218 **Author:** [@briansmith](https://github.com/briansmith) **Created:** 10/2/2017 **Status:** ✅ Merged **Merged:** 10/3/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `no-self-signed-certs` --- ### 📝 Commits (3) - [`bd62757`](https://github.com/hickory-dns/hickory-dns/commit/bd62757a2bc8c6435d28d281589ddc9c20d308f8) Remove the `create_if_absent` TLS certificate feature. - [`4ea5bfe`](https://github.com/hickory-dns/hickory-dns/commit/4ea5bfecf5c050aa371560d882fc43f60eb102a8) Remove `create_if_absent` DNSSEC key feature. - [`8f03ca3`](https://github.com/hickory-dns/hickory-dns/commit/8f03ca33ba5552992dbfe85cd37565d2f4f5c35e) Merge branch 'master' into no-self-signed-certs ### 📊 Changes **6 files changed** (+7 additions, -175 deletions) <details> <summary>View changed files</summary> 📝 `openssl/src/tls_server.rs` (+0 -58) 📝 `server/src/config.rs` (+1 -21) 📝 `server/src/named.rs` (+3 -77) 📝 `server/tests/config_tests.rs` (+1 -10) 📝 `server/tests/named_test_configs/dns_over_tls.toml` (+1 -1) 📝 `server/tests/named_test_configs/example.toml` (+1 -8) </details> ### 📄 Description This is probably a controversial change. I don't fully understand the original motivation for the features being removed (and possibly later moved somewhere else). Consider this more of an RFC or a request for an explanation of which scenerios the features could reasonably be used for. This is a step towards removing `KeyPair::generate()`, KeyPair::generate_pkcs()`, and `KeyFormat::generate_and_encode()`, once the use of those functions is removed from the unit tests, in a separate PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>