[PR #198] [MERGED] Clarify what values are digests and what values are to-be-digested/signed. #1299

New issue

Closed

opened 2026-03-16 01:58:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:58:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/198
Author: @briansmith
Created: 9/22/2017
Status: ✅ Merged
Merged: 9/23/2017
Merged by: @bluejekyll

Base: master ← Head: tbs

📝 Commits (1)

cc9a66b Clarify what values are digests and what values are to-be-digested/signed.

📊 Changes

6 files changed (+110 additions, -89 deletions)

View changed files

📝 client/src/rr/dnssec/keypair.rs (+16 -14)
📝 client/src/rr/dnssec/mod.rs (+1 -1)
📝 client/src/rr/dnssec/signer.rs (+8 -8)
📝 client/src/rr/dnssec/tbs.rs (+62 -46)
📝 client/src/rr/dnssec/verifier.rs (+5 -5)
📝 server/src/authority/authority.rs (+18 -15)

📄 Description

During a previous refactoring the digesting of message contents was moved closer
to the place where the signing is done, to accomodate Ed25519 and crypto APIs
that don't take digests as input to signining functions. However, functions that
used to return digests kept their names with a _hash suffix or hash_ prefix,
which is confusing.

Clarify that by renaming all such functions. Further, introduce a new TBS wrapper
type that further clarifies the intent of the code. "TBS" is a common shorthand
in crypto code standing for "to be signed" data, e.g. tbsCertificate in X.509.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/198 **Author:** [@briansmith](https://github.com/briansmith) **Created:** 9/22/2017 **Status:** ✅ Merged **Merged:** 9/23/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `tbs` --- ### 📝 Commits (1) - [`cc9a66b`](https://github.com/hickory-dns/hickory-dns/commit/cc9a66be851167f2168d684ceb5272c3cfa5abad) Clarify what values are digests and what values are to-be-digested/signed. ### 📊 Changes **6 files changed** (+110 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `client/src/rr/dnssec/keypair.rs` (+16 -14) 📝 `client/src/rr/dnssec/mod.rs` (+1 -1) 📝 `client/src/rr/dnssec/signer.rs` (+8 -8) 📝 `client/src/rr/dnssec/tbs.rs` (+62 -46) 📝 `client/src/rr/dnssec/verifier.rs` (+5 -5) 📝 `server/src/authority/authority.rs` (+18 -15) </details> ### 📄 Description During a previous refactoring the digesting of message contents was moved closer to the place where the signing is done, to accomodate Ed25519 and crypto APIs that don't take digests as input to signining functions. However, functions that used to return digests kept their names with a `_hash` suffix or `hash_` prefix, which is confusing. Clarify that by renaming all such functions. Further, introduce a new TBS wrapper type that further clarifies the intent of the code. "TBS" is a common shorthand in crypto code standing for "to be signed" data, e.g. tbsCertificate in X.509. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>