[PR #195] [MERGED] Remove unnecessary implementations of Verifier & PublicKey. #1292

New issue

Closed

opened 2026-03-16 01:58:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:58:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/195
Author: @briansmith
Created: 9/22/2017
Status: ✅ Merged
Merged: 9/22/2017
Merged by: @bluejekyll

Base: master ← Head: remove-redundant-impls

📝 Commits (1)

e3a43ce Remove unnecessary implementations of Verifier & PublicKey.

📊 Changes

2 files changed (+21 additions, -78 deletions)

View changed files

📝 client/src/rr/dnssec/keypair.rs (+11 -57)
📝 client/src/rr/dnssec/signer.rs (+10 -21)

📄 Description

The code was non-trivially duplicating critical functionality, making improving
it difficult. The PublicKey implementation for KeyPair in particular is highly
duplicative of the normal signature verification path.

Rather than allowing "things that contain public keys" to be used as
public keys, instead insist that the public key be extracted from the
thing and then used.

Note that no non-test code changed, which indicates that some of this was
probably test-only code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/195 **Author:** [@briansmith](https://github.com/briansmith) **Created:** 9/22/2017 **Status:** ✅ Merged **Merged:** 9/22/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `remove-redundant-impls` --- ### 📝 Commits (1) - [`e3a43ce`](https://github.com/hickory-dns/hickory-dns/commit/e3a43ce416ba9fb882dd943c7286deb12f43cd27) Remove unnecessary implementations of Verifier & PublicKey. ### 📊 Changes **2 files changed** (+21 additions, -78 deletions) <details> <summary>View changed files</summary> 📝 `client/src/rr/dnssec/keypair.rs` (+11 -57) 📝 `client/src/rr/dnssec/signer.rs` (+10 -21) </details> ### 📄 Description The code was non-trivially duplicating critical functionality, making improving it difficult. The PublicKey implementation for KeyPair in particular is highly duplicative of the normal signature verification path. Rather than allowing "things that contain public keys" to be used as public keys, instead insist that the public key be extracted from the thing and then used. Note that no non-test code changed, which indicates that some of this was probably test-only code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>