[PR #187] [MERGED] Resolver: Cname chaining #1288

New issue

Closed

opened 2026-03-16 01:58:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:58:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/187
Author: @bluejekyll
Created: 9/13/2017
Status: ✅ Merged
Merged: 9/17/2017
Merged by: @bluejekyll

Base: master ← Head: cname-chaining

📝 Commits (7)

324f8f8 add integration test crate
22e4af8 add some mocked lookup tests for cname
428086b follow cname chain and verify names
7828357 recursive state machine for CNAME chains
28b6482 update some documenation
fffa7e2 add test for max query depth
7ced119 remove erroneous test

📊 Changes

38 files changed (+1087 additions, -497 deletions)

View changed files

📝 .travis.yml (+2 -2)
📝 Cargo.lock (+18 -0)
📝 Cargo.toml (+1 -1)
📝 compatibility-tests/Cargo.toml (+0 -0)
📝 compatibility-tests/src/bind.rs (+6 -4)
📝 compatibility-tests/src/lib.rs (+0 -0)
📝 compatibility-tests/src/none.rs (+0 -0)
📝 compatibility-tests/tests/conf/Kupdate.example.com.+008+56935.key (+0 -0)
📝 compatibility-tests/tests/conf/Kupdate.example.com.+008+56935.pem (+0 -0)
📝 compatibility-tests/tests/conf/Kupdate.example.com.+008+56935.private (+0 -0)
📝 compatibility-tests/tests/conf/README.md (+0 -0)
📝 compatibility-tests/tests/conf/bind-example.com.zone (+0 -0)
📝 compatibility-tests/tests/conf/bind-example.conf (+1 -1)
📝 compatibility-tests/tests/sig0_tests.rs (+1 -1)
➕ integration-tests/Cargo.toml (+53 -0)
📝 integration-tests/src/authority.rs (+0 -0)
📝 integration-tests/src/lib.rs (+29 -17)
➕ integration-tests/src/mock_client.rs (+63 -0)
📝 integration-tests/tests/authority_tests.rs (+2 -6)
➕ integration-tests/tests/catalog_tests.rs (+370 -0)

...and 18 more files

📄 Description

Adding CNAME chained lookups to the Resolver

also fixes: #79 moving all integration tests to /integration-tests

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/187 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 9/13/2017 **Status:** ✅ Merged **Merged:** 9/17/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `cname-chaining` --- ### 📝 Commits (7) - [`324f8f8`](https://github.com/hickory-dns/hickory-dns/commit/324f8f8bdd941288b1140a89cdf95a46b5c16c49) add integration test crate - [`22e4af8`](https://github.com/hickory-dns/hickory-dns/commit/22e4af8f1fe2d3885943cefd71663e9576181599) add some mocked lookup tests for cname - [`428086b`](https://github.com/hickory-dns/hickory-dns/commit/428086b0ae143ebab1d646c77e13aa51def51710) follow cname chain and verify names - [`7828357`](https://github.com/hickory-dns/hickory-dns/commit/7828357b718833175cf46ed5d4b07aa7dec8e208) recursive state machine for CNAME chains - [`28b6482`](https://github.com/hickory-dns/hickory-dns/commit/28b64826b67858bdc2b86a81de950e5c36979160) update some documenation - [`fffa7e2`](https://github.com/hickory-dns/hickory-dns/commit/fffa7e2c3ef77444a117f213cad612369751f705) add test for max query depth - [`7ced119`](https://github.com/hickory-dns/hickory-dns/commit/7ced119f4649475bea779436957472c751e98256) remove erroneous test ### 📊 Changes **38 files changed** (+1087 additions, -497 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+2 -2) 📝 `Cargo.lock` (+18 -0) 📝 `Cargo.toml` (+1 -1) 📝 `compatibility-tests/Cargo.toml` (+0 -0) 📝 `compatibility-tests/src/bind.rs` (+6 -4) 📝 `compatibility-tests/src/lib.rs` (+0 -0) 📝 `compatibility-tests/src/none.rs` (+0 -0) 📝 `compatibility-tests/tests/conf/Kupdate.example.com.+008+56935.key` (+0 -0) 📝 `compatibility-tests/tests/conf/Kupdate.example.com.+008+56935.pem` (+0 -0) 📝 `compatibility-tests/tests/conf/Kupdate.example.com.+008+56935.private` (+0 -0) 📝 `compatibility-tests/tests/conf/README.md` (+0 -0) 📝 `compatibility-tests/tests/conf/bind-example.com.zone` (+0 -0) 📝 `compatibility-tests/tests/conf/bind-example.conf` (+1 -1) 📝 `compatibility-tests/tests/sig0_tests.rs` (+1 -1) ➕ `integration-tests/Cargo.toml` (+53 -0) 📝 `integration-tests/src/authority.rs` (+0 -0) 📝 `integration-tests/src/lib.rs` (+29 -17) ➕ `integration-tests/src/mock_client.rs` (+63 -0) 📝 `integration-tests/tests/authority_tests.rs` (+2 -6) ➕ `integration-tests/tests/catalog_tests.rs` (+370 -0) _...and 18 more files_ </details> ### 📄 Description Adding CNAME chained lookups to the Resolver also fixes: #79 moving all integration tests to /integration-tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>