[PR #162] [MERGED] Use CARGO_PKG_VERSION env var directly without generating version.rs #1273

New issue

Closed

opened 2026-03-16 01:57:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:57:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/162
Author: @Antti
Created: 7/4/2017
Status: ✅ Merged
Merged: 7/4/2017
Merged by: @bluejekyll

Base: master ← Head: remove-build.sh

📝 Commits (1)

cd7500f Use CARGO_PKG_VERSION env var directly without generating version.rs

📊 Changes

10 files changed (+12 additions, -115 deletions)

View changed files

📝 client/Cargo.toml (+0 -3)
➖ client/build.rs (+0 -32)
📝 client/src/lib.rs (+4 -2)
📝 resolver/Cargo.toml (+0 -3)
➖ resolver/build.rs (+0 -32)
📝 resolver/src/lib.rs (+4 -2)
📝 rustls/Cargo.toml (+0 -3)
📝 server/Cargo.toml (+0 -3)
➖ server/build.rs (+0 -33)
📝 server/src/lib.rs (+4 -2)

📄 Description

This removes the need for the custom build.rs script,
as we can use environment variable CARGO_PKG_VERSION directly,
as provided by the cargo.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/162 **Author:** [@Antti](https://github.com/Antti) **Created:** 7/4/2017 **Status:** ✅ Merged **Merged:** 7/4/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `remove-build.sh` --- ### 📝 Commits (1) - [`cd7500f`](https://github.com/hickory-dns/hickory-dns/commit/cd7500fc9364393a071d983def0e5418a8b05324) Use CARGO_PKG_VERSION env var directly without generating version.rs ### 📊 Changes **10 files changed** (+12 additions, -115 deletions) <details> <summary>View changed files</summary> 📝 `client/Cargo.toml` (+0 -3) ➖ `client/build.rs` (+0 -32) 📝 `client/src/lib.rs` (+4 -2) 📝 `resolver/Cargo.toml` (+0 -3) ➖ `resolver/build.rs` (+0 -32) 📝 `resolver/src/lib.rs` (+4 -2) 📝 `rustls/Cargo.toml` (+0 -3) 📝 `server/Cargo.toml` (+0 -3) ➖ `server/build.rs` (+0 -33) 📝 `server/src/lib.rs` (+4 -2) </details> ### 📄 Description This removes the need for the custom build.rs script, as we can use environment variable CARGO_PKG_VERSION directly, as provided by the cargo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>