[PR #148] [MERGED] Fix sig0 key tag #1269

New issue

Closed

opened 2026-03-16 01:57:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:57:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/148
Author: @mwanner
Created: 6/12/2017
Status: ✅ Merged
Merged: 6/13/2017
Merged by: @bluejekyll

Base: master ← Head: fix-sig0-key-tag

📝 Commits (3)

c1cc8f7 Set KeyUsage::Zone for sig0 keys so key tags match with Bind.
93a9308 Add more specific unit tests for key tags on sig0 keys.
94402ab Adjust KeyPair::to_sig0key to remain backwards compatible.

📊 Changes

2 files changed (+107 additions, -20 deletions)

View changed files

📝 client/src/rr/dnssec/keypair.rs (+19 -1)
📝 client/src/rr/dnssec/signer.rs (+88 -19)

📄 Description

Please consider adjusting generation of sig0 keys for key tags matching those of Bind. These adjustments fix #147.

I'm not quite sure on why KeyUsage is deprecated, yet used by Bind9. Maybe adjusting a key generated by dnssec-keygen (from Bind) to use a different KeyUsage would work as well. However, I thought I'd rather try to adjust trust-dns than bind.

Note that the RSA parameters are unaffected, but the key tag depends on the configured key's usage. This information is not included in the PEM format of the RSA key, for example.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/148 **Author:** [@mwanner](https://github.com/mwanner) **Created:** 6/12/2017 **Status:** ✅ Merged **Merged:** 6/13/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix-sig0-key-tag` --- ### 📝 Commits (3) - [`c1cc8f7`](https://github.com/hickory-dns/hickory-dns/commit/c1cc8f71500f29d26d5b49b2fe2c77ea7c71a89a) Set KeyUsage::Zone for sig0 keys so key tags match with Bind. - [`93a9308`](https://github.com/hickory-dns/hickory-dns/commit/93a9308d63a3daa94566ebe8dc53ee7985039243) Add more specific unit tests for key tags on sig0 keys. - [`94402ab`](https://github.com/hickory-dns/hickory-dns/commit/94402ab176273d9e6bafbe1d3677f349e49bba46) Adjust KeyPair::to_sig0key to remain backwards compatible. ### 📊 Changes **2 files changed** (+107 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `client/src/rr/dnssec/keypair.rs` (+19 -1) 📝 `client/src/rr/dnssec/signer.rs` (+88 -19) </details> ### 📄 Description Please consider adjusting generation of sig0 keys for key tags matching those of Bind. These adjustments fix #147. I'm not quite sure on why KeyUsage is deprecated, yet used by Bind9. Maybe adjusting a key generated by dnssec-keygen (from Bind) to use a different KeyUsage would work as well. However, I thought I'd rather try to adjust trust-dns than bind. Note that the RSA parameters are unaffected, but the key tag depends on the configured key's usage. This information is not included in the PEM format of the RSA key, for example. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>