[PR #129] [MERGED] Fix Ed25519 endianness. #1259

New issue

Closed

opened 2026-03-16 01:56:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:56:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/129
Author: @briansmith
Created: 5/9/2017
Status: ✅ Merged
Merged: 5/9/2017
Merged by: @bluejekyll

Base: master ← Head: fix-ed25519

📝 Commits (4)

321c68c Update reference to Ed25519 spec to RFC 8032.
3b01752 Don't reverse the bytes of Ed25519 public keys.
83cdc94 Merge branch 'master' into fix-ed25519
76e13ea Merge branch 'master' into fix-ed25519

📊 Changes

1 file changed (+3 additions, -14 deletions)

View changed files

📝 client/src/rr/dnssec/keypair.rs (+3 -14)

📄 Description

I found the Ed25519-in-DNSSEC spec hard to read but AFAICT it doens't specify an encoding different than the RFC 8032 encoding, so there should be no byte swapping.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/129 **Author:** [@briansmith](https://github.com/briansmith) **Created:** 5/9/2017 **Status:** ✅ Merged **Merged:** 5/9/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix-ed25519` --- ### 📝 Commits (4) - [`321c68c`](https://github.com/hickory-dns/hickory-dns/commit/321c68cfb72a0ed1423a9cbf58da54acdcddbb6a) Update reference to Ed25519 spec to RFC 8032. - [`3b01752`](https://github.com/hickory-dns/hickory-dns/commit/3b017523f498554a3086b9e40eaf04cefbd97756) Don't reverse the bytes of Ed25519 public keys. - [`83cdc94`](https://github.com/hickory-dns/hickory-dns/commit/83cdc9448b6b9b61749046e1dfff174c7a9091fc) Merge branch 'master' into fix-ed25519 - [`76e13ea`](https://github.com/hickory-dns/hickory-dns/commit/76e13ea1f519d8eefaaed23d5b0d45d34ab6d912) Merge branch 'master' into fix-ed25519 ### 📊 Changes **1 file changed** (+3 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `client/src/rr/dnssec/keypair.rs` (+3 -14) </details> ### 📄 Description I found the Ed25519-in-DNSSEC spec hard to read but AFAICT it doens't specify an encoding different than the RFC 8032 encoding, so there should be no byte swapping. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>