[PR #126] [CLOSED] Update ring dependency to 0.9.1. #1256

New issue

Closed

opened 2026-03-16 01:56:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:56:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/126
Author: @briansmith
Created: 5/8/2017
Status: ❌ Closed

Base: master ← Head: update-deps

📝 Commits (1)

9b87aac Update ring dependency to 0.9.1.

📊 Changes

2 files changed (+28 additions, -9 deletions)

View changed files

📝 Cargo.lock (+27 -8)
📝 client/Cargo.toml (+1 -1)

📄 Description

ring 0.9.1 has ECDSA verification features specifically implemented
for Trust-DNS. It is also much easier to build because it has fewer
build dependencies. Note that it requires Rust 1.17.

Note that I don't understand the Cargo.lock stuff. I personally do not keep Cargo.lock under version control. I wonder if maybe it should be removed from version control here?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/126 **Author:** [@briansmith](https://github.com/briansmith) **Created:** 5/8/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `update-deps` --- ### 📝 Commits (1) - [`9b87aac`](https://github.com/hickory-dns/hickory-dns/commit/9b87aacd3176bb94e77b0dc7c8f25d9ee32844c8) Update *ring* dependency to 0.9.1. ### 📊 Changes **2 files changed** (+28 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+27 -8) 📝 `client/Cargo.toml` (+1 -1) </details> ### 📄 Description *ring* 0.9.1 has ECDSA verification features specifically implemented for Trust-DNS. It is also much easier to build because it has fewer build dependencies. Note that it requires Rust 1.17. Note that I don't understand the Cargo.lock stuff. I personally do not keep Cargo.lock under version control. I wonder if maybe it should be removed from version control here? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>