[PR #96] [MERGED] Rename client getter and setter methods #1239

New issue

Closed

opened 2026-03-16 01:55:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:55:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/96
Author: @inejge
Created: 2/27/2017
Status: ✅ Merged
Merged: 2/27/2017
Merged by: @bluejekyll

Base: master ← Head: rename-getter-setter

📝 Commits (10+)

c3b651c Refactor trust_dns::op::Message
f847e6e Refactor trust_dns::op::Header
cbc25e3 Refactor trust_dns::op::Edns
52516fa Refactor trust_dns::op::Query
4db94ba Refactor trust_dns::rr::dnssec::Signer
a61765e Refactor trust_dns::rr::rdata::DNSKEY
d760b83 Refactor trust_dns::rr::rdata::DS
3da0149 Refactor trust_dns::rr::rdata::MX
10f8ce4 Refactor trust_dns::rr::rdata::NSEC
b04818a Refactor trust_dns::rr::rdata::NSEC3

📊 Changes

37 files changed (+1747 additions, -1747 deletions)

View changed files

📝 client/src/client/client_future.rs (+66 -66)
📝 client/src/client/memoize_client_handle.rs (+8 -8)
📝 client/src/client/retry_client_handle.rs (+2 -2)
📝 client/src/client/secure_client_handle.rs (+66 -66)
📝 client/src/op/edns.rs (+27 -27)
📝 client/src/op/header.rs (+28 -28)
📝 client/src/op/message.rs (+145 -145)
📝 client/src/op/query.rs (+6 -6)
📝 client/src/rr/dnssec/signer.rs (+94 -94)
📝 client/src/rr/rdata/dnskey.rs (+10 -10)
📝 client/src/rr/rdata/ds.rs (+10 -10)
📝 client/src/rr/rdata/mx.rs (+4 -4)
📝 client/src/rr/rdata/nsec.rs (+4 -4)
📝 client/src/rr/rdata/nsec3.rs (+14 -14)
📝 client/src/rr/rdata/nsec3param.rs (+9 -9)
📝 client/src/rr/rdata/null.rs (+2 -2)
📝 client/src/rr/rdata/opt.rs (+2 -2)
📝 client/src/rr/rdata/sig.rs (+18 -18)
📝 client/src/rr/rdata/soa.rs (+7 -7)
📝 client/src/rr/rdata/srv.rs (+8 -8)

...and 17 more files

📄 Description

Rename public getters/setters in the client code to conform to RFC#344. In summary:

fn foo(&mut self, ...) renamed to fn set_foo(&mut self, ...);
fn get_foo(&self) renamed to fn foo(&self);
fn is_foo(&self) renamed to fn foo(&self) where appropriate, i.e., where the underlying property is named foo.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/96 **Author:** [@inejge](https://github.com/inejge) **Created:** 2/27/2017 **Status:** ✅ Merged **Merged:** 2/27/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `rename-getter-setter` --- ### 📝 Commits (10+) - [`c3b651c`](https://github.com/hickory-dns/hickory-dns/commit/c3b651c8360ae79e6c34f33084b423da74db52e6) Refactor trust_dns::op::Message - [`f847e6e`](https://github.com/hickory-dns/hickory-dns/commit/f847e6e61139545ef23de9dfc5018164430010e7) Refactor trust_dns::op::Header - [`cbc25e3`](https://github.com/hickory-dns/hickory-dns/commit/cbc25e37185ba6f9ddbdd8e7c285648b4119bd10) Refactor trust_dns::op::Edns - [`52516fa`](https://github.com/hickory-dns/hickory-dns/commit/52516fac6bf6db260fc251425ddb1d5311f5bb0e) Refactor trust_dns::op::Query - [`4db94ba`](https://github.com/hickory-dns/hickory-dns/commit/4db94bac451659aca9527faa0aa02232bfb63863) Refactor trust_dns::rr::dnssec::Signer - [`a61765e`](https://github.com/hickory-dns/hickory-dns/commit/a61765ecdfdb0d0cd67ab643d92d1e2c0bb228d0) Refactor trust_dns::rr::rdata::DNSKEY - [`d760b83`](https://github.com/hickory-dns/hickory-dns/commit/d760b83ca34b8e4e2b46425c0bca298698673545) Refactor trust_dns::rr::rdata::DS - [`3da0149`](https://github.com/hickory-dns/hickory-dns/commit/3da0149101f0fbcfe2fc2e65792441a2b142795e) Refactor trust_dns::rr::rdata::MX - [`10f8ce4`](https://github.com/hickory-dns/hickory-dns/commit/10f8ce4d01a0b932117ace07a39a25d021dfabf1) Refactor trust_dns::rr::rdata::NSEC - [`b04818a`](https://github.com/hickory-dns/hickory-dns/commit/b04818a92b05d4f5b6fd92cad209ff0ff2ab7e47) Refactor trust_dns::rr::rdata::NSEC3 ### 📊 Changes **37 files changed** (+1747 additions, -1747 deletions) <details> <summary>View changed files</summary> 📝 `client/src/client/client_future.rs` (+66 -66) 📝 `client/src/client/memoize_client_handle.rs` (+8 -8) 📝 `client/src/client/retry_client_handle.rs` (+2 -2) 📝 `client/src/client/secure_client_handle.rs` (+66 -66) 📝 `client/src/op/edns.rs` (+27 -27) 📝 `client/src/op/header.rs` (+28 -28) 📝 `client/src/op/message.rs` (+145 -145) 📝 `client/src/op/query.rs` (+6 -6) 📝 `client/src/rr/dnssec/signer.rs` (+94 -94) 📝 `client/src/rr/rdata/dnskey.rs` (+10 -10) 📝 `client/src/rr/rdata/ds.rs` (+10 -10) 📝 `client/src/rr/rdata/mx.rs` (+4 -4) 📝 `client/src/rr/rdata/nsec.rs` (+4 -4) 📝 `client/src/rr/rdata/nsec3.rs` (+14 -14) 📝 `client/src/rr/rdata/nsec3param.rs` (+9 -9) 📝 `client/src/rr/rdata/null.rs` (+2 -2) 📝 `client/src/rr/rdata/opt.rs` (+2 -2) 📝 `client/src/rr/rdata/sig.rs` (+18 -18) 📝 `client/src/rr/rdata/soa.rs` (+7 -7) 📝 `client/src/rr/rdata/srv.rs` (+8 -8) _...and 17 more files_ </details> ### 📄 Description Rename public getters/setters in the client code to conform to [RFC#344](https://github.com/aturon/rfcs/blob/conventions-galore/active/0000-conventions-galore.md#gettersetter-apis). In summary: * `fn foo(&mut self, ...)` renamed to `fn set_foo(&mut self, ...)`; * `fn get_foo(&self)` renamed to `fn foo(&self)`; * `fn is_foo(&self)` renamed to `fn foo(&self)` where appropriate, i.e., where the underlying property is named `foo`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>