[PR #87] [MERGED] Old client to future #1235

New issue

Closed

opened 2026-03-16 01:55:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:55:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/87
Author: @bluejekyll
Created: 1/15/2017
Status: ✅ Merged
Merged: 1/16/2017
Merged by: @bluejekyll

Base: master ← Head: old_client_to_future

📝 Commits (5)

5d81644 restructured SyncClient
6e7d78a original client now updated to use the ClientFuture
feace4f Merge branch 'master' into old_client_to_future
39c8813 Merge branch 'master' into old_client_to_future
aa0216a Merge branch 'master' into old_client_to_future

📊 Changes

22 files changed (+380 additions, -1792 deletions)

View changed files

📝 CHANGELOG.md (+17 -1)
📝 Cargo.lock (+0 -41)
📝 README.md (+0 -11)
📝 client/Cargo.toml (+1 -4)
📝 client/src/client/client.rs (+228 -777)
📝 client/src/client/client_connection.rs (+9 -10)
📝 client/src/client/client_future.rs (+0 -2)
📝 client/src/client/mod.rs (+1 -5)
📝 client/src/lib.rs (+0 -2)
📝 client/src/tcp/mod.rs (+3 -8)
📝 client/src/tcp/tcp_client_connection.rs (+13 -124)
📝 client/src/tcp/tcp_stream.rs (+1 -1)
📝 client/src/udp/mod.rs (+3 -8)
📝 client/src/udp/udp_client_connection.rs (+15 -146)
📝 client/src/udp/udp_stream.rs (+1 -1)
📝 server/Cargo.toml (+0 -1)
📝 server/src/lib.rs (+0 -3)
📝 server/src/server/mod.rs (+0 -3)
➖ server/src/server/server.rs (+0 -424)
📝 server/tests/client_tests.rs (+72 -84)

...and 2 more files

📄 Description

Rearchitected the original Client into SyncClient and SecureSyncClient. This is a breaking change.

@zsck if you have a minute, would you mind looking at this and let me know if these changes are too aggressive? It should be a relatively straightforward upgrade. You're currently the only person I know is relying on this.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/87 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 1/15/2017 **Status:** ✅ Merged **Merged:** 1/16/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `old_client_to_future` --- ### 📝 Commits (5) - [`5d81644`](https://github.com/hickory-dns/hickory-dns/commit/5d816444b65a0c13ac702b4885f4e85858467b3f) restructured SyncClient - [`6e7d78a`](https://github.com/hickory-dns/hickory-dns/commit/6e7d78a8f41cacb1ce6cc327bfd25b0fe9f8b56e) original client now updated to use the ClientFuture - [`feace4f`](https://github.com/hickory-dns/hickory-dns/commit/feace4fc18e1a60f21e4d28e70e540029b6ec038) Merge branch 'master' into old_client_to_future - [`39c8813`](https://github.com/hickory-dns/hickory-dns/commit/39c881361bb7148ccb80c80127e3d11075d47256) Merge branch 'master' into old_client_to_future - [`aa0216a`](https://github.com/hickory-dns/hickory-dns/commit/aa0216a0da67a11183a5812db61b82a005f2e0db) Merge branch 'master' into old_client_to_future ### 📊 Changes **22 files changed** (+380 additions, -1792 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+17 -1) 📝 `Cargo.lock` (+0 -41) 📝 `README.md` (+0 -11) 📝 `client/Cargo.toml` (+1 -4) 📝 `client/src/client/client.rs` (+228 -777) 📝 `client/src/client/client_connection.rs` (+9 -10) 📝 `client/src/client/client_future.rs` (+0 -2) 📝 `client/src/client/mod.rs` (+1 -5) 📝 `client/src/lib.rs` (+0 -2) 📝 `client/src/tcp/mod.rs` (+3 -8) 📝 `client/src/tcp/tcp_client_connection.rs` (+13 -124) 📝 `client/src/tcp/tcp_stream.rs` (+1 -1) 📝 `client/src/udp/mod.rs` (+3 -8) 📝 `client/src/udp/udp_client_connection.rs` (+15 -146) 📝 `client/src/udp/udp_stream.rs` (+1 -1) 📝 `server/Cargo.toml` (+0 -1) 📝 `server/src/lib.rs` (+0 -3) 📝 `server/src/server/mod.rs` (+0 -3) ➖ `server/src/server/server.rs` (+0 -424) 📝 `server/tests/client_tests.rs` (+72 -84) _...and 2 more files_ </details> ### 📄 Description Rearchitected the original Client into SyncClient and SecureSyncClient. This is a breaking change. @zsck if you have a minute, would you mind looking at this and let me know if these changes are too aggressive? It should be a relatively straightforward upgrade. You're currently the only person I know is relying on this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>