[PR #82] [MERGED] Ring eddsa support #1229

New issue

Closed

opened 2026-03-16 01:55:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:55:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/82
Author: @bluejekyll
Created: 1/8/2017
Status: ✅ Merged
Merged: 1/10/2017
Merged by: @bluejekyll

Base: master ← Head: ring_eddsa_support

📝 Commits (10+)

1f31d7e refactor to allow multiple key implementations
3e0a40c add byte format test for trust_keys
eeaacec upgrade to OpenSSL 0.9
8b3a47f EC support in KeyPair
464e74b Merge branch 'master' into openssl_ecdsa_support
a73d309 add support for ed25519 with ring, #60
40fe11f add some docs, and fix no-default-features
b087203 refactor server fr new KeyPair changes
5cc588e clean up DS and DNSKEY creation
413a95a fix ed25519 usage and add serialization tests

📊 Changes

37 files changed (+1337 additions, -397 deletions)

View changed files

📝 CHANGELOG.md (+6 -0)
📝 Cargo.lock (+42 -8)
📝 client/Cargo.toml (+3 -2)
📝 client/src/client/client.rs (+3 -3)
📝 client/src/client/mod.rs (+1 -2)
📝 client/src/client/secure_client_handle.rs (+34 -57)
📝 client/src/error/dnssec_error.rs (+26 -4)
📝 client/src/lib.rs (+4 -0)
📝 client/src/op/message.rs (+1 -1)
📝 client/src/rr/dnssec/algorithm.rs (+52 -12)
📝 client/src/rr/dnssec/digest_type.rs (+18 -10)
📝 client/src/rr/dnssec/keypair.rs (+450 -64)
📝 client/src/rr/dnssec/nsec3.rs (+2 -1)
📝 client/src/rr/dnssec/signer.rs (+23 -14)
📝 client/src/rr/dnssec/supported_algorithm.rs (+37 -8)
📝 client/src/rr/dnssec/trust_anchor.rs (+1 -1)
📝 client/src/rr/domain.rs (+50 -0)
📝 client/src/rr/rdata/dnskey.rs (+47 -1)
📝 client/src/rr/rdata/ds.rs (+32 -0)
📝 client/src/rr/rdata/opt.rs (+5 -0)

...and 17 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/82 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 1/8/2017 **Status:** ✅ Merged **Merged:** 1/10/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `ring_eddsa_support` --- ### 📝 Commits (10+) - [`1f31d7e`](https://github.com/hickory-dns/hickory-dns/commit/1f31d7e80d3c79199bf829d6ee30c916949b15d6) refactor to allow multiple key implementations - [`3e0a40c`](https://github.com/hickory-dns/hickory-dns/commit/3e0a40cc9245219b1567415c664487d7e13a3453) add byte format test for trust_keys - [`eeaacec`](https://github.com/hickory-dns/hickory-dns/commit/eeaacec9458d1b75c7fe4b8bc24c2b06d13f3f92) upgrade to OpenSSL 0.9 - [`8b3a47f`](https://github.com/hickory-dns/hickory-dns/commit/8b3a47f0fceca3108bb24eb4597383b445053ba6) EC support in KeyPair - [`464e74b`](https://github.com/hickory-dns/hickory-dns/commit/464e74b771ce39a12c024ff6d12650e30b807bc8) Merge branch 'master' into openssl_ecdsa_support - [`a73d309`](https://github.com/hickory-dns/hickory-dns/commit/a73d30913686a3c55852475b8bce55bb18b0eaba) add support for ed25519 with ring, #60 - [`40fe11f`](https://github.com/hickory-dns/hickory-dns/commit/40fe11f1b8ef8cb13af7e201fd837d75ac3c70a9) add some docs, and fix no-default-features - [`b087203`](https://github.com/hickory-dns/hickory-dns/commit/b087203c62aacca515d9f7cce27f5da582fb906f) refactor server fr new KeyPair changes - [`5cc588e`](https://github.com/hickory-dns/hickory-dns/commit/5cc588ebc4ad94d3663671a485de2cb31d958c15) clean up DS and DNSKEY creation - [`413a95a`](https://github.com/hickory-dns/hickory-dns/commit/413a95ab7f3da7b7196e2f72987e509116726bdf) fix ed25519 usage and add serialization tests ### 📊 Changes **37 files changed** (+1337 additions, -397 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+6 -0) 📝 `Cargo.lock` (+42 -8) 📝 `client/Cargo.toml` (+3 -2) 📝 `client/src/client/client.rs` (+3 -3) 📝 `client/src/client/mod.rs` (+1 -2) 📝 `client/src/client/secure_client_handle.rs` (+34 -57) 📝 `client/src/error/dnssec_error.rs` (+26 -4) 📝 `client/src/lib.rs` (+4 -0) 📝 `client/src/op/message.rs` (+1 -1) 📝 `client/src/rr/dnssec/algorithm.rs` (+52 -12) 📝 `client/src/rr/dnssec/digest_type.rs` (+18 -10) 📝 `client/src/rr/dnssec/keypair.rs` (+450 -64) 📝 `client/src/rr/dnssec/nsec3.rs` (+2 -1) 📝 `client/src/rr/dnssec/signer.rs` (+23 -14) 📝 `client/src/rr/dnssec/supported_algorithm.rs` (+37 -8) 📝 `client/src/rr/dnssec/trust_anchor.rs` (+1 -1) 📝 `client/src/rr/domain.rs` (+50 -0) 📝 `client/src/rr/rdata/dnskey.rs` (+47 -1) 📝 `client/src/rr/rdata/ds.rs` (+32 -0) 📝 `client/src/rr/rdata/opt.rs` (+5 -0) _...and 17 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>