mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[GH-ISSUE #243] Requests for unsupported types time out #115
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#115
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rushmorem on GitHub (Oct 21, 2017).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/243
For example
returns the following error message
NB: This is from a minimal custom server based on version
0.12.0using an emptyCatalogas the request handler.@Darkspirit commented on GitHub (Oct 21, 2017):
Maybe at least returning some sort of response for all RFC'd types listed here: https://github.com/bluejekyll/trust-dns/blob/master/proto/src/rr/record_type.rs#L32 (and keep ignoring unknown types (for some type of DoS protection))?
@rushmorem commented on GitHub (Oct 21, 2017):
Aren't we supposed to simply return with NotImp in cases like these?
@bluejekyll commented on GitHub (Oct 23, 2017):
Thanks for the report. NotImp may not be the best option in this case, it’s prbably better to just return an empty recordset. My guess is that the code is hitting an error on the record type parsing and then bailing on the request.
So that code path should be fixed.