mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 19:25:56 +03:00
[GH-ISSUE #3087] resolver(docs): MAX_TTL is not public #1127
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#1127
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Kriskras99 on GitHub (Jun 25, 2025).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/3087
Describe the bug
(
ResolverOpts.positive_max_ttl)[https://docs.rs/hickory-resolver/0.25.2/hickory_resolver/config/struct.ResolverOpts.html#structfield.positive_max_ttl] andResolverOpts.negative_max_ttlrefer to MAX_TTL as the default value. However this value ispub(crate)and therefore not accessible. The link in the docs does not work and returns a 404.To Reproduce
Go to https://docs.rs/hickory-resolver/0.25.2/hickory_resolver/config/struct.ResolverOpts.html#structfield.positive_max_ttl and click on
MAX_TTL.Expected behavior
Being able to view
MAX_TTLor have it specified asOtherwise, this will default to a unspecified amount of seconds.Version:
Crate: resolver
Version: 0.25.2
Additional context
I can open a PR for making
MAX_TTLpublic or removing the link and not specifying a default.@djc commented on GitHub (Jun 25, 2025):
Sorry for the oversight, happy to review your PR!