mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[GH-ISSUE #2940] ServerOrderingStrategy::QueryStats should not honor timing for REFUSED results. #1094
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#1094
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @issackelly on GitHub (Apr 17, 2025).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2940
Describe the bug
I'm looking closely at the ServerOrderingStrategy and I think I might have an interesting situation in the field.
I do not currently have a minimal reproduction but a close reading of the code suggests there may be some edge cases.
I think that I have configured TCP+UDP upstream, but the TCP may be always returning REFUSED. It is possible that's happening fairly quickly and we may be preferring TCP connections due to that behavior. I'm wondering if the stats recording needs a filter to only record stats for certain kinds of answers or something.
Additional context
Add any other context about the problem here.