[GH-ISSUE #2853] Recursor builder should take a list of IP addresses #1075

New issue

Closed

opened 2026-03-16 01:32:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:32:45 +03:00

Owner

Originally created by @divergentdave on GitHub (Mar 14, 2025).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2853

Currently RecursorBuilder::build() takes an impl Into<NameServerConfigGroup>. This is more complicated to use than it needs to be. The recursor already builds NameServerConfigGroups for all other zones, so any extra flexibility this provides for the root zone's name server pool is not very meaningful. Furthermore, it's easy to get wrong. If name server configs with Protocol::Tcp are not included, then truncated responses become fatal errors. This method should instead take a list of IP addresses, and then construct the root zone's name server pool in the same way we do for all other zones.

Originally created by @divergentdave on GitHub (Mar 14, 2025). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2853 Currently `RecursorBuilder::build()` takes an `impl Into<NameServerConfigGroup>`. This is more complicated to use than it needs to be. The recursor already builds `NameServerConfigGroup`s for all other zones, so any extra flexibility this provides for the root zone's name server pool is not very meaningful. Furthermore, it's easy to get wrong. If name server configs with `Protocol::Tcp` are not included, then truncated responses become fatal errors. This method should instead take a list of IP addresses, and then construct the root zone's name server pool in the same way we do for all other zones.