[GH-ISSUE #2661] hickory-proto 0.24.1 is affected by RUSTSEC-2024-0421 #1040

Closed
opened 2026-03-16 01:24:41 +03:00 by kerem · 6 comments
Owner

Originally created by @MarkusPettersson98 on GitHub (Dec 9, 2024).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2661

Hello!

Just want to let you know that the latest release of hickory-proto is affected by RUSTSEC-2024-0421 because of its dependence on idna 0.4.0. The solution is to upgrade to idna 1.0.0 (at least), which was done in the 0.25.4-alpha.4 release.

Originally created by @MarkusPettersson98 on GitHub (Dec 9, 2024). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2661 Hello! Just want to let you know that the latest release of `hickory-proto` is affected by [RUSTSEC-2024-0421](https://rustsec.org/advisories/RUSTSEC-2024-0421) because of its dependence on `idna 0.4.0`. The solution is to upgrade to `idna 1.0.0` (at least), which was done in the [`0.25.4-alpha.4 release`](https://github.com/hickory-dns/hickory-dns/releases/tag/v0.25.0-alpha.4).
kerem closed this issue 2026-03-16 01:24:46 +03:00
Author
Owner

@djc commented on GitHub (Dec 9, 2024):

Yes, we're aware. For now, the recommended mitigation is to upgrade to 0.25.0-alpha.4, although I guess we could probably release a 0.24.2 if there's strong demand for it.

<!-- gh-comment-id:2528668614 --> @djc commented on GitHub (Dec 9, 2024): Yes, we're aware. For now, the recommended mitigation is to upgrade to 0.25.0-alpha.4, although I guess we could probably release a 0.24.2 if there's strong demand for it.
Author
Owner

@svix-jplatte commented on GitHub (Dec 9, 2024):

Upgrading to the alpha is only really an option if the only dependency on hickory is your own, rather than an indirect one (e.g. via reqwest's hickory-dns feature). A patch release would be appreciated.

<!-- gh-comment-id:2528683716 --> @svix-jplatte commented on GitHub (Dec 9, 2024): Upgrading to the alpha is only really an option if the only dependency on hickory is your own, rather than an indirect one (e.g. via reqwest's `hickory-dns` feature). A patch release would be appreciated.
Author
Owner

@DDtKey commented on GitHub (Dec 9, 2024):

First of all, thank you for the maintenance!

I've temporary switched to a patched version from my fork, and probably it can be an option to release 0.24.2?
I've opened a PR just in case https://github.com/hickory-dns/hickory-dns/pull/2662

Because waiting major release is an issue, it involves many transient deps. Updating a patch version is much simpler to fix vulnerability

Currently, if anyone interested in using my workaround, here it is:

[patch.crates-io]
proto = { package = "hickory-proto", git = "https://github.com/DDtKey/hickory-dns.git", branch = "release-0.24/patch-idna" }
<!-- gh-comment-id:2528796692 --> @DDtKey commented on GitHub (Dec 9, 2024): First of all, thank you for the maintenance! I've temporary switched to a patched version from my fork, and probably it can be an option to release `0.24.2`? I've opened a PR just in case https://github.com/hickory-dns/hickory-dns/pull/2662 Because waiting major release is an issue, it involves many transient deps. Updating a patch version is much simpler to fix vulnerability Currently, if anyone interested in using my workaround, here it is: ``` [patch.crates-io] proto = { package = "hickory-proto", git = "https://github.com/DDtKey/hickory-dns.git", branch = "release-0.24/patch-idna" } ```
Author
Owner

@x86pup commented on GitHub (Dec 9, 2024):

A 0.24.2 release would be appreciated. My project uses 0.24.1 for now as there are some breaking changes in 0.25.0, so we can't upgrade at the moment.

<!-- gh-comment-id:2528810558 --> @x86pup commented on GitHub (Dec 9, 2024): A 0.24.2 release would be appreciated. My project uses 0.24.1 for now as there are some breaking changes in 0.25.0, so we can't upgrade at the moment.
Author
Owner

@MarkusPettersson98 commented on GitHub (Dec 9, 2024):

We would also appreciate a patch release, even though it is not critical 😊

<!-- gh-comment-id:2528859068 --> @MarkusPettersson98 commented on GitHub (Dec 9, 2024): We would also appreciate a patch release, even though it is not critical :blush:
Author
Owner

@djc commented on GitHub (Dec 10, 2024):

We've released 0.24.2 versions of all the crates. @DDtKey thanks for your efforts on fixing this!

<!-- gh-comment-id:2531817129 --> @djc commented on GitHub (Dec 10, 2024): We've released 0.24.2 versions of all the crates. @DDtKey thanks for your efforts on fixing this!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#1040
No description provided.