starred/hickory-dns

Fork 0

mirror of https://github.com/hickory-dns/hickory-dns.git synced 2026-04-25 11:15:54 +03:00

[GH-ISSUE #2639] Confusion of algorithm numbers between DAU, DHU, and N3U #1032

New issue

Closed

opened 2026-03-16 01:20:06 +03:00 by kerem · 6 comments

kerem commented

2026-03-16 01:20:06 +03:00

Owner

Originally created by @divergentdave on GitHub (Dec 5, 2024).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2639

Currently, the DAU, DHU, and N3U EDNS options are all internally represented with the SupportedAlgorithms struct, which is a customized bitfield for DNSSEC signing algorithms. Relatedly, Edns::set_default_algorithms() inserts the DAU and DHU options with the same set of algorithms in each. However, algorithm codes have different semantics between the three options, as they are drawn from different IANA registries.

The internal representations of DHU and N3U options should be changed to distinct bitfield types, or lists of DigestType and Nsec3HashAlgorithm. Edns::set_default_algorithms() should report 1, 2, and 4 in the DHU option, for SHA-1, SHA-256, and SHA-384. We could also add the N3U option, with just 1 for SHA-1.

Originally created by @divergentdave on GitHub (Dec 5, 2024). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2639 Currently, the DAU, DHU, and N3U EDNS options are all internally represented with the `SupportedAlgorithms` struct, which is a customized bitfield for DNSSEC signing algorithms. Relatedly, `Edns::set_default_algorithms()` inserts the DAU and DHU options with the same set of algorithms in each. However, algorithm codes have different semantics between the three options, as they are drawn from different IANA registries. The internal representations of DHU and N3U options should be changed to distinct bitfield types, or lists of `DigestType` and `Nsec3HashAlgorithm`. `Edns::set_default_algorithms()` should report 1, 2, and 4 in the DHU option, for SHA-1, SHA-256, and SHA-384. We could also add the N3U option, with just 1 for SHA-1.

kerem closed this issue

2026-03-16 01:20:11 +03:00

kerem commented

2026-03-16 01:20:17 +03:00

Author

Owner

@bluejekyll commented on GitHub (Mar 2, 2025):

I think you cleaned this up recently, right?

@bluejekyll commented on GitHub (Mar 2, 2025): I think you cleaned this up recently, right?

kerem commented

2026-03-16 01:22:47 +03:00

Author

Owner

@bluejekyll commented on GitHub (Mar 2, 2025):

I think you cleaned this up recently, right?

@bluejekyll commented on GitHub (Mar 2, 2025): I think you cleaned this up recently, right?

kerem commented

2026-03-16 01:22:52 +03:00

Author

Owner

@djc commented on GitHub (Mar 2, 2025):

I guess you're referring to #2753?

@djc commented on GitHub (Mar 2, 2025): I guess you're referring to #2753?

kerem commented

2026-03-16 01:22:57 +03:00

Author

Owner

@divergentdave commented on GitHub (Mar 2, 2025):

Yes, #2753 removed the DHU and N3U options.

@divergentdave commented on GitHub (Mar 2, 2025): Yes, #2753 removed the DHU and N3U options.

kerem commented

2026-03-16 01:23:02 +03:00

Author

Owner

@djc commented on GitHub (Mar 2, 2025):

@divergentdave so can this be closed?

@djc commented on GitHub (Mar 2, 2025): @divergentdave so can this be closed?

kerem commented

2026-03-16 01:23:08 +03:00

Author

Owner

@divergentdave commented on GitHub (Mar 2, 2025):

Yes, we can add these options back later if there's interest, and track that in a separate issue.

@divergentdave commented on GitHub (Mar 2, 2025): Yes, we can add these options back later if there's interest, and track that in a separate issue.

kerem referenced this issue

2026-03-16 03:10:43 +03:00

[PR #1032] [CLOSED] Bump tokio-rustls from 0.12.2 to 0.13.0 #1892