mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 19:25:56 +03:00
[GH-ISSUE #2577] Recursor: Use glue A/AAAA records from responses to NS queries #1020
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#1020
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @divergentdave on GitHub (Nov 15, 2024).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2577
I noticed that
ns_pool_for_referral()can get IP addresses from the query cache, from glue records in the referral, or by making new requests, whilens_pool_for_zone()can only get IP addresses from the query cache or by making requests. I experimented with some NS queries, and it looks like it's common for nameservers to return glue A/AAAA records in the additional section. Thus, we could try using the additional section first, and cut out a round trip in many cases.@divergentdave commented on GitHub (Nov 15, 2024):
Nevermind, I did some further testing, and
DnsLru::insert_records()caches the glue A/AAAA records from the additional section under a separate A/AAAA query. The glue records from the NS query are getting included when building pools, but indirectly, via the cache.