[GH-ISSUE #2571] Separate traits for querying for a stream of responses vs. a single response #1017

New issue

Open

opened 2026-03-16 01:17:38 +03:00 by kerem · 2 comments

kerem commented

2026-03-16 01:17:38 +03:00

Owner

Originally created by @divergentdave on GitHub (Nov 12, 2024).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2571

The following TODO suggests changing DnsHandle to return one response instead of a stream of responses.

github.com/hickory-dns/hickory-dns@64953998f8/crates/recursor/src/recursor_dns_handle.rs (L384-L385)

A stream of responses is needed for mDNS and DNS-SD use cases, but using the same trait for RecursorDnsHandle and DnssecDnsHandle, which produce exactly one response, adds complexity to their implementation and use.

See also #383 and #1478.

Originally created by @divergentdave on GitHub (Nov 12, 2024). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2571 The following TODO suggests changing `DnsHandle` to return one response instead of a stream of responses. https://github.com/hickory-dns/hickory-dns/blob/64953998f8350d3cc8ebf125316e9e734182a7c5/crates/recursor/src/recursor_dns_handle.rs#L384-L385 A stream of responses is needed for mDNS and DNS-SD use cases, but using the same trait for `RecursorDnsHandle` and `DnssecDnsHandle`, which produce exactly one response, adds complexity to their implementation and use. See also #383 and #1478.

kerem commented

2026-03-16 01:17:45 +03:00

Author

Owner

@djc commented on GitHub (Nov 12, 2024):

Aren't there also other cases in normal resolving where we want to yield multiple results for a single query (like with EDNS or just over TCP)?

@djc commented on GitHub (Nov 12, 2024): Aren't there also other cases in normal resolving where we want to yield multiple results for a single query (like with EDNS or just over TCP)?

kerem commented

2026-03-16 01:17:50 +03:00

Author

Owner

@bluejekyll commented on GitHub (Mar 2, 2025):

Yeah, this is a generic issue, I'm not sure what we should really do here. We also need a stream for AXFR I believe. I'm definitely open to ideas here.

@bluejekyll commented on GitHub (Mar 2, 2025): Yeah, this is a generic issue, I'm not sure what we should really do here. We also need a stream for AXFR I believe. I'm definitely open to ideas here.