[GH-ISSUE #2516] Make ForwardAuthority generic over its ConnectionProvider #1012

New issue

Closed

opened 2026-03-16 01:16:29 +03:00 by kerem · 1 comment

kerem commented

2026-03-16 01:16:29 +03:00

Owner

Originally created by @Stormshield-robinc on GitHub (Oct 17, 2024).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2516

The ForwardAuthority has the TokioAsyncResolver type hardcoded and there is no generic type.

Is your feature request related to a problem? Please describe.

On our project, we ended up in a situation where we need a forwarder, but for some sockets we need to apply specials options to the UDP socket.
All the code around AsyncResolver is nicely generic and allows us to simply wrap TokioRuntimeProvider to fit our needs. But sadly the ForwardAuthority is not generic on the ConnectionProvider it uses, which forced us to copy/past its implementation.

Describe the solution you'd like
It would be very nice to have a ForwardAuthority that would be generic on its connection provider, so we could cleanly override it.
In order to avoid breaking retro-compatibility it could be another type (something like "ForwardAuthorityGeneric") and ForwardAuthority would simply specify this type.

Would it be OK for you ? (I can provide a PR)

Describe alternatives you've considered
n/a

Additional context
n/a

Originally created by @Stormshield-robinc on GitHub (Oct 17, 2024). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2516 The `ForwardAuthority` has the `TokioAsyncResolver` type hardcoded and there is no generic type. **Is your feature request related to a problem? Please describe.** On our project, we ended up in a situation where we need a forwarder, but for some sockets we need to apply specials options to the UDP socket. All the code around `AsyncResolver` is nicely generic and allows us to simply wrap `TokioRuntimeProvider` to fit our needs. But sadly the `ForwardAuthority` is not generic on the `ConnectionProvider` it uses, which forced us to copy/past its implementation. **Describe the solution you'd like** It would be very nice to have a `ForwardAuthority` that would be generic on its connection provider, so we could cleanly override it. In order to avoid breaking retro-compatibility it could be another type (something like "ForwardAuthorityGeneric") and `ForwardAuthority` would simply specify this type. Would it be OK for you ? (I can provide a PR) **Describe alternatives you've considered** n/a **Additional context** n/a

kerem

2026-03-16 01:16:29 +03:00

closed this issue
added the
cleanup
label

kerem commented

2026-03-16 01:16:46 +03:00

Author

Owner

@djc commented on GitHub (Oct 17, 2024):

PR sounds good, no need to do backwards compatibility as we're going to release a semver-incompatible release anyway.

@djc commented on GitHub (Oct 17, 2024): PR sounds good, no need to do backwards compatibility as we're going to release a semver-incompatible release anyway.

kerem referenced this issue

2026-03-16 02:36:56 +03:00

[PR #1012] [MERGED] Bump webpki from 0.21.0 to 0.21.2 #1863

kerem referenced this issue

2026-03-16 02:51:45 +03:00

[PR #1012] [MERGED] Bump webpki from 0.21.0 to 0.21.2 #1867