mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[GH-ISSUE #2526] Test client_tests::test_timeout_query_tcp fails with some internet connections #1011
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#1011
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @divergentdave on GitHub (Oct 23, 2024).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2526
Describe the bug
This test is almost always failing on my USI fiber connection, but passes when using a T-Mobile 4G connection via tethering. The test makes a TCP connection to 203.0.113.0, and expects to get a timeout error, but gets "No route to host (os error 113)" instead. This IP address is in
TEST-NET-3from RFC 5737. This regressed in commitf6b7c4be77.To Reproduce
Steps to reproduce the behavior:
Run
cargo test --all-features -p hickory-integration --test integration -- client_tests::test_timeout_query_tcp.Expected behavior
This test should pass reliably.
System:
Version:
Crate: client
Version: Tip of main
Additional context
There is a very similar test in
client_future_tests, but that test only checks that connecting fails, and doesn't check which type of error it gets.Edit: FWIW, the difference between networks is that, on USI, I get an ICMP "Time-to-live exceeded" message after about 1.5 seconds. On T-Mobile, there are no messages sent back, and my computer just keeps sending TCP retransmissions. Seeing a "Time-to-live exceeded" error is unfortunate, as it sounds like there may be a routing loop, but such is life. Note that the TCP connection may also fail quickly when trying to run tests while offline.