mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 19:25:56 +03:00
[GH-ISSUE #2510] Allow adding dns options in hickory_client::client::Client #1007
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#1007
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mat813 on GitHub (Oct 16, 2024).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2510
Is your feature request related to a problem? Please describe.
I rewrote a small utility called dnstracer into rust https://crates.io/crates/dnstracer and there are a couple of flags I was not able to really implement, those are setting the EDNS0 bit when making a query, and setting the EDNS0 buffer.
The code I use to make each dns query is here https://gitlab.com/mat813/dnstracer-rs/-/blob/v0.9.1/src/resolver.rs?ref_type=tags#L227-241
Describe the solution you'd like
Would like to be able to set more options DNS options in hickory_client::client::Client.
Describe alternatives you've considered
I looked into the code and there is a use_edns field in AsyncClient, but I could not figure out how to set it when using the SyncClient.
@djc commented on GitHub (Oct 16, 2024):
I'd suggest just using
AsyncClientand wrapping it in ablock_on()call or similar. Any reason you're avoid the async API?@mat813 commented on GitHub (Oct 16, 2024):
I am not trying to avoid the async API, I found examples of how to work with the Sync API, and as the utility I am writing is simple, I don't need any async features.
@djc commented on GitHub (Jan 20, 2025):
The synchronous
ClientAPI was removed in #2521.