mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[PR #511] [CLOSED] Dark mode #981
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#981
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/healthchecks/healthchecks/pull/511
Author: @andyloree
Created: 5/8/2021
Status: ❌ Closed
Base:
master← Head:dark-mode📝 Commits (1)
556bc2dDark mode📊 Changes
14 files changed (+590 additions, -1 deletions)
View changed files
➕
static/css/badges-dark.css(+4 -0)➕
static/css/base-dark.css(+36 -0)➕
static/css/bootstrap-dark.css(+382 -0)➕
static/css/channels-dark.css(+30 -0)➕
static/css/details-dark.css(+4 -0)➕
static/css/docs-dark.css(+19 -0)➕
static/css/log-dark.css(+20 -0)➕
static/css/login-dark.css(+4 -0)➕
static/css/my_checks-dark.css(+5 -0)➕
static/css/my_checks_desktop-dark.css(+46 -0)➕
static/css/profile-dark.css(+3 -0)➕
static/css/projects-dark.css(+10 -0)➕
static/css/welcome-dark.css(+13 -0)📝
templates/base.html(+14 -1)📄 Description
For your consideration, the following are the minimal CSS files (all suffixed with
-dark), placed after the corresponding existing CSS files in thebase.html, with themedia="(prefers-color-scheme: dark)"attribute. This will respect browse/OS settings for dark mode rendering.Certainly possible to change this behavior a per-user saved preference or similar code-driven option as opposed to browser preference driven, but I thought this would present a minimal change, no-code, option.
One draw back to this implementation is any older browser that doesn't support theme preference will render dark mode by default. A workaround to this would be to leverage per-page JS to assist correct loading on older browsers, which I would be happy to add.
Below are screen shots of the dark mode in use:
01 - Welcome Screen

02 - Login/Signup

03 - Docs

04 - Projects

05 - Checks

06 - Check Details

07 - Integrations

08 - Badges

09 - Settings

I tested using Firefox and Chromium, and emulated mobile rendering. It is possible that may have missed a few dark-on-dark rendering issues (tried my best to test all pages/areas).
Thank you for your consideration, and for making such an excellently simple tool for healthcheck monitoring.
Andrew
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.