mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 23:15:49 +03:00
[PR #492] [MERGED] [DOCKER] Fix failing docker build on arm due to cryptography trying to build rust #976
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#976
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/healthchecks/healthchecks/pull/492
Author: @chevalier-m
Created: 3/11/2021
Status: ✅ Merged
Merged: 3/11/2021
Merged by: @cuu508
Base:
master← Head:master📝 Commits (1)
431f37f[DOCKER] Fix failing build on armhf, due to cryptography lib trying to build rust📊 Changes
1 file changed (+1 additions, -0 deletions)
View changed files
📝
docker/Dockerfile(+1 -0)📄 Description
Build on my raspberry pi 4 (
armhf) was failing due to the cryptography python package trying to build Rust dependency. Find below a snippet taken from the build logs:My fix is greatly (to say the least) inspired by https://github.com/docker/compose/issues/8105#issuecomment-775879420 . It consists simply of adding
ENV CRYPTOGRAPHY_DONT_BUILD_RUST=1in theDockerfileprior to the pip installation.I don't think that the Rust dependency was ever used in this project, so it shouldn't impact the vast majority of users.
I also believe, that if someone needs it, he probably created his own Dockerfile to handle his scenarios.
I have it confirmed working on both my
armhfand myamd64machines.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.