[PR #488] [MERGED] Added formatting on ping.body in emails #973

New issue

Closed

opened 2026-02-26 00:30:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 00:30:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/488
Author: @cocide
Created: 3/5/2021
Status: ✅ Merged
Merged: 3/8/2021
Merged by: @cuu508

Base: master ← Head: patch-2

📝 Commits (1)

e0e3b6f Added formatting on ping.body in emails

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 templates/emails/alert-body-html.html (+1 -1)

📄 Description

Not all email clients are formatting the ping.body contents uniformly. Even using different applications from the same email provider results in a different display of the ping.body contents. There are two basic issues:

Not all email clients are honoring the fixed-width font that should be used inside <pre> tags. Using fixed-width font is listed in the definition on https://www.w3schools.com/tags/tag_pre.asp
Not all email clients are displaying the text with a 1em line height. This was a recent change to the healthchecks WebUI in 9fd9c8e4ef but is not part of the definition of the <pre> tag. I'd like to add this to the emails to make Healthchecks more uniform between the website and the email notification.

Gmail Webmail:

Is using fixed-width font
Line height is set by the webmail client to 18px

Gmail Android App:

Text is not fixed-width
Line height has extra padding

ProtonMail Webmail:

Is using fixed-width font
Line height is correct

ProtonMail Android:

Text is not fixed width
Line height has extra padding

The testing I performed is not extensive, but it does show how multiple clients are displaying the contents differently. To make the display of the ping.body more uniform I'd like to add a bit of formatting information to the <pre> tag.

Gmail Webmail Screenshot:

Gmail Android Screenshot:

ProtonMail Webmail Screenshot:

ProtonMail Android Screenshot:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/488 **Author:** [@cocide](https://github.com/cocide) **Created:** 3/5/2021 **Status:** ✅ Merged **Merged:** 3/8/2021 **Merged by:** [@cuu508](https://github.com/cuu508) **Base:** `master` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`e0e3b6f`](https://github.com/healthchecks/healthchecks/commit/e0e3b6fbb26e1b522e991821124be63a5024e4ef) Added formatting on ping.body in emails ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `templates/emails/alert-body-html.html` (+1 -1) </details> ### 📄 Description Not all email clients are formatting the `ping.body` contents uniformly. Even using different applications from the same email provider results in a different display of the `ping.body` contents. There are two basic issues: * Not all email clients are honoring the fixed-width font that should be used inside `<pre>` tags. Using fixed-width font is listed in the definition on https://www.w3schools.com/tags/tag_pre.asp * Not all email clients are displaying the text with a 1em line height. This was a recent change to the healthchecks WebUI in 9fd9c8e4efd0c87c015215ae56eada88a7d07b6b but is not part of the definition of the `<pre>` tag. I'd like to add this to the emails to make Healthchecks more uniform between the website and the email notification. Gmail Webmail: - [x] Is using fixed-width font - [ ] Line height is set by the webmail client to 18px Gmail Android App: - [ ] Text is not fixed-width - [ ] Line height has extra padding ProtonMail Webmail: - [x] Is using fixed-width font - [x] Line height is correct ProtonMail Android: - [ ] Text is not fixed width - [ ] Line height has extra padding The testing I performed is not extensive, but it does show how multiple clients are displaying the contents differently. To make the display of the `ping.body` more uniform I'd like to add a bit of formatting information to the `<pre>` tag. Gmail Webmail Screenshot: ![Gmail Webmail](https://user-images.githubusercontent.com/544915/110149236-686c4780-7da3-11eb-9b7d-726103bb07dd.png) Gmail Android Screenshot: ![Gmail Android](https://user-images.githubusercontent.com/544915/110149234-67d3b100-7da3-11eb-9eab-2ef19ccffd14.png) ProtonMail Webmail Screenshot: ![ProtonMail Webmail](https://user-images.githubusercontent.com/544915/110149240-6904de00-7da3-11eb-8f44-e3e7b8643a04.png) ProtonMail Android Screenshot: ![ProtonMail Android](https://user-images.githubusercontent.com/544915/110149238-6904de00-7da3-11eb-978b-dbe12296cc28.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>