[PR #483] [CLOSED] Changing static height and width to be constraints #970

New issue

Closed

opened 2026-02-26 00:30:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 00:30:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/483
Author: @jameskirsop
Created: 2/23/2021
Status: ❌ Closed

Base: master ← Head: correctly-proprtion-logo

📝 Commits (1)

93c6b7c Changing static height and width to be constraints

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 templates/base.html (+4 -4)

📄 Description

This commit allows for logo.png (and it's scaled alternates) to keep their own proportions while still being constrained in the existing bounds of the base layout for each page. Without this change, custom logos that don't exactly match the proportions (50x59, 50x200) are skewed to fill the bounds.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/483 **Author:** [@jameskirsop](https://github.com/jameskirsop) **Created:** 2/23/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `correctly-proprtion-logo` --- ### 📝 Commits (1) - [`93c6b7c`](https://github.com/healthchecks/healthchecks/commit/93c6b7ccad38a5db5911a7be25ef91b2d7627ade) Changing static height and width to be constraints ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `templates/base.html` (+4 -4) </details> ### 📄 Description This commit allows for logo.png (and it's scaled alternates) to keep their own proportions while still being constrained in the existing bounds of the base layout for each page. Without this change, custom logos that don't exactly match the proportions (50x59, 50x200) are skewed to fill the bounds. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>