[PR #360] [MERGED] Remove redundant '-X POST' to curl #938

New issue

Closed

opened 2026-02-25 23:44:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:44:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/360
Author: @bdd
Created: 4/18/2020
Status: ✅ Merged
Merged: 4/19/2020
Merged by: @cuu508

Base: master ← Head: master

📝 Commits (1)

34807dc Remove redundant '-X POST' to curl

📊 Changes

4 files changed (+12 additions, -12 deletions)

View changed files

📝 templates/docs/attaching_logs.html (+4 -4)
📝 templates/docs/attaching_logs.md (+4 -4)
📝 templates/docs/bash.html (+2 -2)
📝 templates/docs/bash.md (+2 -2)

📄 Description

Passing --data-raw to curl implies the request is method will be POST.
Unless we intend to do something entirely different, -X method override
shouldn't be used.

Curl's author Daniel Stenberg (@bagder) wrote about this back in 2015
https://daniel.haxx.se/blog/2015/09/11/unnecessary-use-of-curl-x/

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/360 **Author:** [@bdd](https://github.com/bdd) **Created:** 4/18/2020 **Status:** ✅ Merged **Merged:** 4/19/2020 **Merged by:** [@cuu508](https://github.com/cuu508) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`34807dc`](https://github.com/healthchecks/healthchecks/commit/34807dc5aac59570c59c96ab63e72ebaf068367b) Remove redundant '-X POST' to curl ### 📊 Changes **4 files changed** (+12 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `templates/docs/attaching_logs.html` (+4 -4) 📝 `templates/docs/attaching_logs.md` (+4 -4) 📝 `templates/docs/bash.html` (+2 -2) 📝 `templates/docs/bash.md` (+2 -2) </details> ### 📄 Description Passing `--data-raw` to curl implies the request is method will be POST. Unless we intend to do something entirely different, -X method override shouldn't be used. Curl's author Daniel Stenberg (@bagder) wrote about this back in 2015 https://daniel.haxx.se/blog/2015/09/11/unnecessary-use-of-curl-x/ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>