[PR #320] [MERGED] Increase allowable length of Matrix room alias #929

Closed
opened 2026-02-25 23:44:10 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/320
Author: @jerrykan
Created: 1/16/2020
Status: Merged
Merged: 1/16/2020
Merged by: @cuu508

Base: masterHead: matrix_alias_length


📝 Commits (1)

  • 819aa22 Increase allowable length of Matrix room alias

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 hc/front/forms.py (+1 -1)

📄 Description

The existing 40 character limit prevents using the integration will Matrix servers that might have a fairly lengthy hostname (ie. 'matrix.internal.example.com' would only allow 12 characters for the
room name or ID, and room IDs are 19 characters long).

Increasing the max_length to 100 is still fairly arbitrary but itdoes match up with the max_length of the name field of the Channel model and should cover most instances.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/320 **Author:** [@jerrykan](https://github.com/jerrykan) **Created:** 1/16/2020 **Status:** ✅ Merged **Merged:** 1/16/2020 **Merged by:** [@cuu508](https://github.com/cuu508) **Base:** `master` ← **Head:** `matrix_alias_length` --- ### 📝 Commits (1) - [`819aa22`](https://github.com/healthchecks/healthchecks/commit/819aa227e9e6faa78b079e01c1ec0e22b194af79) Increase allowable length of Matrix room alias ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `hc/front/forms.py` (+1 -1) </details> ### 📄 Description The existing 40 character limit prevents using the integration will Matrix servers that might have a fairly lengthy hostname (ie. 'matrix.internal.example.com' would only allow 12 characters for the room name or ID, and room IDs are 19 characters long). Increasing the `max_length` to `100` is still fairly arbitrary but itdoes match up with the `max_length` of the `name` field of the `Channel` model and should cover most instances. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 23:44:10 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/healthchecks#929
No description provided.