mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-26 07:25:51 +03:00
[PR #320] [MERGED] Increase allowable length of Matrix room alias #929
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#929
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/healthchecks/healthchecks/pull/320
Author: @jerrykan
Created: 1/16/2020
Status: ✅ Merged
Merged: 1/16/2020
Merged by: @cuu508
Base:
master← Head:matrix_alias_length📝 Commits (1)
819aa22Increase allowable length of Matrix room alias📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
hc/front/forms.py(+1 -1)📄 Description
The existing 40 character limit prevents using the integration will Matrix servers that might have a fairly lengthy hostname (ie. 'matrix.internal.example.com' would only allow 12 characters for the
room name or ID, and room IDs are 19 characters long).
Increasing the
max_lengthto100is still fairly arbitrary but itdoes match up with themax_lengthof thenamefield of theChannelmodel and should cover most instances.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.