mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-24 22:45:56 +03:00
[PR #217] [MERGED] Allow SMTP configuration via environment variables #915
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#915
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/healthchecks/healthchecks/pull/217
Author: @timfreund
Created: 2/1/2019
Status: ✅ Merged
Merged: 2/1/2019
Merged by: @cuu508
Base:
master← Head:configure-smtp-with-environment📝 Commits (1)
415ec58Allow SMTP configuration via environment variables📊 Changes
2 files changed (+14 additions, -1 deletions)
View changed files
📝
README.md(+7 -1)📝
hc/settings.py(+7 -0)📄 Description
This change allows SMTP configuration via email, but users can still choose to configure the settings directly in local_settings.py
This is helpful for docker-compose workflows: we configure a local mailhog container for development and we use a mailgun account for production. The account settings for each are passed in via deployment specific environment files.
I'm open to suggestions for improving this PR. Thanks!
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.