[PR #34] [MERGED] remove channel should always redirect even if removal fails #873

New issue

Closed

opened 2026-02-25 23:43:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:43:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/34
Author: @diwu1989
Created: 1/19/2016
Status: ✅ Merged
Merged: 1/20/2016
Merged by: @cuu508

Base: master ← Head: removeCHannel

📝 Commits (2)

01a9505 remove channel doesn't crash
625d2cf comment

📊 Changes

2 files changed (+7 additions, -6 deletions)

View changed files

📝 hc/front/tests/test_remove_channel.py (+1 -1)
📝 hc/front/views.py (+6 -5)

📄 Description

removing the channel may be a slow operation and if the user refresh in the middle of the request, Chrome will make a 2nd POST request, which will end up erroring

I think it's better to always redirect the user to the channel list regardless of whether the removal UUID was valid or not, better than showing an error page if the user sends two removals simultaneously

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/34 **Author:** [@diwu1989](https://github.com/diwu1989) **Created:** 1/19/2016 **Status:** ✅ Merged **Merged:** 1/20/2016 **Merged by:** [@cuu508](https://github.com/cuu508) **Base:** `master` ← **Head:** `removeCHannel` --- ### 📝 Commits (2) - [`01a9505`](https://github.com/healthchecks/healthchecks/commit/01a9505cc7874472cbfde6961949188e0479df59) remove channel doesn't crash - [`625d2cf`](https://github.com/healthchecks/healthchecks/commit/625d2cf298e06499ed63b9255aabfffdeb82f940) comment ### 📊 Changes **2 files changed** (+7 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `hc/front/tests/test_remove_channel.py` (+1 -1) 📝 `hc/front/views.py` (+6 -5) </details> ### 📄 Description removing the channel may be a slow operation and if the user refresh in the middle of the request, Chrome will make a 2nd POST request, which will end up erroring I think it's better to always redirect the user to the channel list regardless of whether the removal UUID was valid or not, better than showing an error page if the user sends two removals simultaneously --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>