[PR #30] [MERGED] use basetestcase for most test cases that require predefined user #869

New issue

Closed

opened 2026-02-25 23:43:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:43:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/30
Author: @diwu1989
Created: 1/18/2016
Status: ✅ Merged
Merged: 1/18/2016
Merged by: @cuu508

Base: master ← Head: fixTests

📝 Commits (1)

fe72792 use basetestcase for most test cases that require predefined user, add test for ensuretriggers, add travis cache

📊 Changes

28 files changed (+129 additions, -169 deletions)

View changed files

📝 .travis.yml (+1 -0)
📝 hc/accounts/tests/test_check_token.py (+2 -9)
📝 hc/api/management/commands/ensuretriggers.py (+18 -13)
📝 hc/api/tests/test_email_webhook.py (+1 -0)
➕ hc/api/tests/test_ensuretriggers.py (+27 -0)
📝 hc/api/tests/test_notify.py (+4 -7)
📝 hc/api/tests/test_ping.py (+1 -0)
📝 hc/api/tests/test_sendalerts.py (+9 -10)
📝 hc/api/tests/test_status.py (+1 -0)
📝 hc/front/tests/test_add_channel.py (+5 -13)
📝 hc/front/tests/test_add_check.py (+2 -9)
📝 hc/front/tests/test_basics.py (+1 -0)
📝 hc/front/tests/test_channel_checks.py (+3 -6)
📝 hc/front/tests/test_log.py (+3 -6)
📝 hc/front/tests/test_my_checks.py (+2 -7)
📝 hc/front/tests/test_remove_channel.py (+3 -6)
📝 hc/front/tests/test_remove_check.py (+3 -6)
📝 hc/front/tests/test_update_channel.py (+3 -6)
📝 hc/front/tests/test_update_name.py (+3 -6)
📝 hc/front/tests/test_update_timeout.py (+3 -6)

...and 8 more files

📄 Description

should not be duplicating so much code for the base test case setup

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/30 **Author:** [@diwu1989](https://github.com/diwu1989) **Created:** 1/18/2016 **Status:** ✅ Merged **Merged:** 1/18/2016 **Merged by:** [@cuu508](https://github.com/cuu508) **Base:** `master` ← **Head:** `fixTests` --- ### 📝 Commits (1) - [`fe72792`](https://github.com/healthchecks/healthchecks/commit/fe72792fd23ac9dc3fdf441425547bea3f700616) use basetestcase for most test cases that require predefined user, add test for ensuretriggers, add travis cache ### 📊 Changes **28 files changed** (+129 additions, -169 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+1 -0) 📝 `hc/accounts/tests/test_check_token.py` (+2 -9) 📝 `hc/api/management/commands/ensuretriggers.py` (+18 -13) 📝 `hc/api/tests/test_email_webhook.py` (+1 -0) ➕ `hc/api/tests/test_ensuretriggers.py` (+27 -0) 📝 `hc/api/tests/test_notify.py` (+4 -7) 📝 `hc/api/tests/test_ping.py` (+1 -0) 📝 `hc/api/tests/test_sendalerts.py` (+9 -10) 📝 `hc/api/tests/test_status.py` (+1 -0) 📝 `hc/front/tests/test_add_channel.py` (+5 -13) 📝 `hc/front/tests/test_add_check.py` (+2 -9) 📝 `hc/front/tests/test_basics.py` (+1 -0) 📝 `hc/front/tests/test_channel_checks.py` (+3 -6) 📝 `hc/front/tests/test_log.py` (+3 -6) 📝 `hc/front/tests/test_my_checks.py` (+2 -7) 📝 `hc/front/tests/test_remove_channel.py` (+3 -6) 📝 `hc/front/tests/test_remove_check.py` (+3 -6) 📝 `hc/front/tests/test_update_channel.py` (+3 -6) 📝 `hc/front/tests/test_update_name.py` (+3 -6) 📝 `hc/front/tests/test_update_timeout.py` (+3 -6) _...and 8 more files_ </details> ### 📄 Description should not be duplicating so much code for the base test case setup --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>