[PR #14] [MERGED] redirect already logged in user #861

New issue

Closed

opened 2026-02-25 23:43:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:43:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/14
Author: @diwu1989
Created: 11/28/2015
Status: ✅ Merged
Merged: 12/2/2015
Merged by: @cuu508

Base: master ← Head: loggedIn

📝 Commits (1)

427a042 redirect already logged in user

📊 Changes

3 files changed (+23 additions, -7 deletions)

View changed files

📝 hc/accounts/tests/test_check_token.py (+17 -6)
📝 hc/accounts/views.py (+4 -0)
📝 hc/front/views.py (+2 -1)

📄 Description

If the user is already logged in, and then click the login email again, they get hit with this:

The reason is that their login token has been reset already, but they do have a valid session at the moment.

Correct behavior is to redirect the user to the checks screen instead.

and a small perf change that I saw while reading through the code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/14 **Author:** [@diwu1989](https://github.com/diwu1989) **Created:** 11/28/2015 **Status:** ✅ Merged **Merged:** 12/2/2015 **Merged by:** [@cuu508](https://github.com/cuu508) **Base:** `master` ← **Head:** `loggedIn` --- ### 📝 Commits (1) - [`427a042`](https://github.com/healthchecks/healthchecks/commit/427a0421c86bb80165c5a46c073106d549c0c3af) redirect already logged in user ### 📊 Changes **3 files changed** (+23 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `hc/accounts/tests/test_check_token.py` (+17 -6) 📝 `hc/accounts/views.py` (+4 -0) 📝 `hc/front/views.py` (+2 -1) </details> ### 📄 Description If the user is already logged in, and then click the login email again, they get hit with this: ![image](https://cloud.githubusercontent.com/assets/380950/11450960/f6543ff0-9567-11e5-8554-9fc589807f49.png) The reason is that their login token has been reset already, but they do have a valid session at the moment. Correct behavior is to redirect the user to the checks screen instead. and a small perf change that I saw while reading through the code --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>