mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 23:15:49 +03:00
[GH-ISSUE #1236] Text report mismatches columns for new checks #835
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#835
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @adelton on GitHub (Dec 1, 2025).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/1236
I just got an email monthly report for November from
docker.io/healthchecks/healthchecks:v3.13. I notice that the text/plain version mismatches theAll good!for checks that were only created in November, putting it to October. The report looks like this (redacted):Looking at
github.com/healthchecks/healthchecks@5e274e6aeb/templates/emails/report-body-text.html (L19-L35)there should be aThe check didn't exist yetthere in October column but it looks like{% for d in check.past_downtimes %}does not get to loop over October at all.@adelton commented on GitHub (Dec 1, 2025):
Ah, unlike the HTML version
github.com/healthchecks/healthchecks@5e274e6aeb/templates/emails/report-summary-html.html (L75-L81)which adds the<td>...</td>around the wholeif...endif, the text version has thecellonly in theAll good!case.Filed https://github.com/healthchecks/healthchecks/pull/1237 with a proposed fix.
@cuu508 commented on GitHub (Dec 1, 2025):
Thanks for the report and the PR, good catch!