mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[GH-ISSUE #1222] No Popup after API-Key creation #827
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#827
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @hagen-bauer-regioit on GitHub (Oct 24, 2025).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/1222
I am running healthcheck selfhosted. When I create an api key there is no dialog box to copy the key. It just creates the key. I Assume this happens after the last update to 3.11.2. There is no error in the Browser console and it is the same behaviour on Chrome and Firefox. I do get popups when revoking a key.
Any hints where to look for errors would be appreciated
Hagen
@cuu508 commented on GitHub (Oct 27, 2025):
Thanks for the report!
I'm assuming the issue is when creating a ping key, not the API key?
For API keys, we need to display the dialog because Healthchecks stores API keys in a hashed form and so can only show them right after the generation.
Healthchecks stores ping keys in plain text, and so can show them to the user at any time. The user can reveal the full ping key by clicking on the masked version (I'm guessing this is unintuitive, hence the issue). I didn't add a popup for ping keys because they don't strictly need it. But for the sake of consistency, I've added it now, looks like so:
@hagen-bauer-regioit commented on GitHub (Oct 28, 2025):
@cuu508 There is NO dialog box when creating an API key and I can also not view a mask version of a ping key.
@cuu508 commented on GitHub (Oct 28, 2025):
@hagen-bauer-regioit ah, I see. In that case, my first suspect would be old JS cached by the browser. Could you try opening web developer tools (this usually disables cache) and revoke/create an API key then?
Also, in your Healthchecks instance, is the DEBUG setting set to False? With DEBUG=False Healthchecks uses django-compressor to combine JS and CSS files, which should also take care of cache invalidation. With DEBUG=True (or django-compressor disabled some other way), I would expect the browser to cache static files and cause issues similar to what you describe.
@hagen-bauer-regioit commented on GitHub (Oct 28, 2025):
Debug is set to False and disabling cache via developer tools didnt help either :-(
@cuu508 commented on GitHub (Oct 28, 2025):
What version of Healthchecks are you running? If you are using docker, what image and version are you using?
@hagen-bauer-regioit commented on GitHub (Oct 28, 2025):
I updated to 3.11.2 using this procedure
@cuu508 commented on GitHub (Oct 28, 2025):
Unfortunately so far I haven't been able to reproduce the issue.
I tried the following steps:
I then logged in using the same credentials as in
manage.py createsuperuser, created an API key and saw the popup.@cuu508 commented on GitHub (Oct 28, 2025):
You have
./manage.py makemigrationsin the list of your commands, and you are also installing jwt. Do you have any local modifications or extra files? Anything interesting in local_settings.py?@cuu508 commented on GitHub (Oct 28, 2025):
And another question, after upgrading to v3.11.2, did you run
manage.py collectstaticandmanage.py compress? (see "Management commands that need to be run during each deployment" here).@hagen-bauer-regioit commented on GitHub (Oct 28, 2025):
the jwt installation was necessary because there was someting missing and the "make migration" was something manage.py migrate told be to do.
but its working now. I have now run
I have not seen this as part of the upgrade and misintetpretated "part of every deployment".
I will try to make a better documentation for my next upgrade and maybe this will help to add a dedicated "update/upgrade" chapter.